When 'site_mail' variable is not empty, it always override 'From' header

CommentFileSizeAuthor
#18 2714749-17.patch656 bytesdawehner
#17 2714749-17.patch997 bytesdawehner
#15 2714749-15.patch610 bytesdawehner
#12 site_mail_variable-2714749-12.patch1.54 KBnileshlohar
#10 site_mail_variable-2714749-10.patch1.5 KBnileshlohar
#8 smtp-site_mail_overrides_from_header-2714749-8.patch2.04 KBdbiscalchin
#5 smtp-site_mail_overrides_from_header-2714749-5.patch1.02 KBtheterencechan
#2 smtp-site_mail_overrides_from_header-2714749-2-7.x-2.x.patch697 byteshenrikenji
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

henrikenji created an issue. See original summary.

henrikenji’s picture

henrikenji CreditAttribution: henrikenji commented
FileSize
smtp-site_mail_overrides_from_header-2714749-2-7.x-2.x.patch697 bytes

Just removed the code that forced to 'site_mail' variable to be always 'From' header

henrikenji’s picture

henrikenji CreditAttribution: henrikenji commented
Status: Active » Needs review
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

Is this a (partial) duplicate of #1686588: Use From address properly?

theterencechan’s picture

theterencechan CreditAttribution: theterencechan commented
FileSize
smtp-site_mail_overrides_from_header-2714749-5.patch1.02 KB

With patch #2, for my webform, the site email become the email address for "on behalf of" my from email address in my webform. I added a sender header to get rid of this as well. The patch was created for the 7.x-1.x version.

djpable’s picture

djpable CreditAttribution: djpable as a volunteer commented

I think that the correct "From" string should be $from_name that is now unused in mailWithoutQueue() method....

Simplenews
Mime Mail
Mail System
Smtp Authentication
Drupal 7.52

stack is really broken after 7.50 update and Smtp Authentication support 1.4 !!

dbiscalchin’s picture

dbiscalchin CreditAttribution: dbiscalchin commented
Status: Needs review » Needs work

Moving to "Needs work", because both "Sender" and "Return-Path" headers should be set to the "From" value provided in the module settings.

dbiscalchin’s picture

dbiscalchin CreditAttribution: dbiscalchin commented
FileSize
smtp-site_mail_overrides_from_header-2714749-8.patch2.04 KB

This patch fixes both "Sender" and "Return-Path" headers. It works on 2.x branch.

I've also removed some code that apparently would never be reached, because $from couldn't be empty at that point.

dbiscalchin’s picture

dbiscalchin CreditAttribution: dbiscalchin commented
Status: Needs work » Needs review
nileshlohar’s picture

nileshlohar CreditAttribution: nileshlohar commented
FileSize
site_mail_variable-2714749-10.patch1.5 KB

Patch for the latest release.

Status: Needs review » Needs work

The last submitted patch, 10: site_mail_variable-2714749-10.patch, failed testing.

nileshlohar’s picture

nileshlohar CreditAttribution: nileshlohar commented
Version: 7.x-2.x-dev » 7.x-1.x-dev
FileSize
site_mail_variable-2714749-12.patch1.54 KB

Re-rolling it.

jrochate’s picture

jrochate CreditAttribution: jrochate commented

Thanks! 7.x-1.x patch works flawless.

jrochate’s picture

jrochate CreditAttribution: jrochate commented

Well, actually I found that From: is being sent twice on mail headers.

So, some ISP are considering it as non-RFC a rejecting mail (google does).

Had to revert patch, since I didn't find with line was wrong.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Needs work » Needs review
FileSize
2714749-15.patch610 bytes

Here is a patch which seemed to do something similar in D8.

Status: Needs review » Needs work

The last submitted patch, 15: 2714749-15.patch, failed testing. View results

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
FileSize
2714749-17.patch997 bytes

This still had issues with the 'Sender' header.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
FileSize
2714749-17.patch656 bytes

Oops, it contained the .patch file.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

This is duplicate of #1686588: Use From address properly