If the Colorbox Drupal module is already installed on a site then this module overwrites the libraries info for it.

Combined with the fact this module's version regex is currently broken (see #2349179: The version of the Colorbox plugin library could not be detected.) this causes the colorbox module's library to be overwritten by a broken one from this module.

CommentFileSizeAuthor
#2 popup_onload-dont_overwrite_colorbox_library-2714029-2.patch2.01 KBrooby

Comments

rooby created an issue. See original summary.

rooby’s picture

rooby commented
Status: Active » Needs review
StatusFileSize
new popup_onload-dont_overwrite_colorbox_library-2714029-2.patch2.01 KB

This patch detects whether or not the colorbox module is defining the library and if so doesn't define anything in hook_libraries_info().

Status: Needs review » Needs work

The last submitted patch, 2: popup_onload-dont_overwrite_colorbox_library-2714029-2.patch, failed testing.

rooby’s picture

rooby commented
Status: Needs work » Needs review

That doesn't seem to be a problem with the patch.

matthiasm11’s picture

matthiasm11 commented

I can confirm the patch from #2 works.

flightrisk’s picture

flightrisk commented

Can someone tell me how to fix this? Do I have to re-install an older version, then apply the patch to this version and try to update again?

  • itcrowd72 committed ab7ef9a on 7.x-1.x 
    Issue #2714029 by rooby, itcrowd72: Don't overwrite colorbox module...
ivnish’s picture

ivnish
he/him
commented
Status: Needs review » Fixed

  • itcrowd72 committed 5a86e89 on 7.x-1.x authored by rooby 
    Issue #2714029 by rooby, itcrowd72: Don't overwrite colorbox module...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.