Closed (fixed)
Project:
Popup On Load
Version:
7.x-1.1
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Oct 2014 at 20:09 UTC
Updated:
2 Oct 2018 at 11:28 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
tropicfruit commentedSame here.
Comment #2
smurfxx commentedSame here, I downloaded latest colorbox plugin in sites/all/libraries so the full url is [site]/sites/all/libraries/colorbox/jquery.colorbox-min.js but it isn't detected as good.
Comment #3
d.novikov commentedHey guys, I see the issue is a critical one. Will look at this today.
@smurfxx, thank you for paying my attention to this!
Comment #4
smurfxx commentedThank you too, I think this is a great and easy to use module so I will support you!
Comment #5
d.novikov commentedPushed a fixed to the dev snapshot. Check this out, guys!
Comment #7
smurfxx commentedVery good, now it detect colorbox library!
Comment #8
d.novikov commentedThanks for the review, @smurfxx! Closing out this.
Comment #9
webpotato commentedSorry d., still not fixed for me. Behaves just the same.
Comment #10
d.novikov commentedComment #11
rmartinezsoler commentedHi guys,
'pattern' => '@(?i:Colorbox)\sv?([0-9\.a-z]+)@', -> Doesn't work
'pattern' => '@(?i:Colorbox)(?: | v)([0-9\.?]+)@', ->Doesn't work
Nothing works?
JS Library in folder .../sites/all/libraries/colorbox doesn't work
JS Library in folder .../sites/all/libraries/colorbox/colorbox doesn't work
Then, COLORBOX Module doesn't work, it is not posible to install correctly this module..This module is completely obsolete
This module should be reported to Drupal.
Comment #12
dshields commentedYeah, this needs help
Comment #13
ggive commentedHi guys,
This still not fixed for me either
Comment #14
toby wild commentedManaged to fix it by copying the Colorbox modules Regex.
I'm terrible at .patch files, so just do this:
popup_onload.module
Line: 237
Replace:
'pattern' => '@Colorbox.+([0-9\.a-z]+)@',With:
'pattern' => '@(?i:Colorbox)\sv?([0-9\.a-z]+)@',Comment #15
dshields commentedI tried to help out by creating a patch here, but in testing this solution, I didn't see any change in the module's ability to find the colorbox library.
Comment #16
dshields commentedComment #17
jwilson3I had success with version 1.6.0 (and master) and the following Regex:
@Colorbox\s+?v?([0-9\.a-z]+)@.Note: thoroughly untested on older versions.
Comment #18
dshields commentedSorry, bad testing on my part: It seems that Toby's solution in #14 does work nicely! Thanks for this: here's a patch, credited to Toby.
Comment #19
dshields commentedPatch ready for review
Comment #21
jwilson3#18 works for me. Thanks!
Shameless plug: I'd appreciate feedback & review from other community members on my other small patches for this module:
* #2469231: Missing local task (tab) for /admin/content/popup_onload page
* #2469195: Redirected to admin/structure/popup_onload after save
Comment #22
tea2sugars commentedToby's solution worked for me, thanks bud!
https://www.drupal.org/node/2349179#comment-9752019
Comment #23
steve.m commentedWhy not refactor to use the libraries API the way the colorbox module does?
and
Comment #24
steve.m commentedAaah, wait. It's the libraries_detect() step that throws the error. Nevermind.
Comment #25
rooby commentedI opened a related issue #2714029: Don't overwrite colorbox module library. This issue is still relevant though for users who aren't also using the Colorbox module.
Comment #27
ivnishComment #28
ivnish