Problem/Motivation

Not all entities have a _self href use UUID instead in dependency graph

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

larowlan created an issue. See original summary.

larowlan’s picture

Status: Active » Needs review
StatusFileSize
new2.8 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2713985-uuid-not-self.2.patch, failed testing.

larowlan’s picture

Status: Needs work » Needs review
StatusFileSize
new1.16 KB
new9.51 KB

Our test dumps were out of date

larowlan’s picture

StatusFileSize
new3.97 KB

Wrong remote

The last submitted patch, 4: 2713985-uuid-not-self.4.patch, failed testing.

berdir’s picture

  1. +++ b/src/DefaultContentManager.php
    @@ -172,36 +172,37 @@ class DefaultContentManager implements DefaultContentManagerInterface {
               // Throw an exception when this URL already exists.
    -          if (isset($file_map[$self])) {
    +          if (isset($file_map[$item_uuid])) {
    

    this UUID

  2. +++ b/src/DefaultContentManager.php
    @@ -172,36 +172,37 @@ class DefaultContentManager implements DefaultContentManagerInterface {
    -              '@href' => $self,
    -              '@first' => $file_map[$self]->uri,
    +              '@uuid' => $item_uuid,
    +              '@first' => $file_map[$item_uuid]->uri,
                   '@second' => $file->uri,
                 );
                 // Reset link domain.
                 $this->linkManager->setLinkDomain(FALSE);
    -            throw new \Exception(SafeMarkup::format('Default content with href @href exists twice: @first @second', $args));
    +            throw new \Exception(SafeMarkup::format('Default content with uuid @uuid exists twice: @first @second', $args));
    

    What is uri here exactly? What does it show for paragraph that doesn't have a uri/link?

larowlan’s picture

Updating credits

  • larowlan committed bcd2efb on 8.x-1.x
    Issue #2713985 by larowlan: Not all entities have a _self href use UUID...
  • larowlan committed c6a79ee on 8.x-1.x
    Issue #2713985 by larowlan: Not all entities have a _self href use UUID...
  • larowlan committed ce46fbb on 8.x-1.x
    Issue #2713985 by larowlan: Not all entities have a _self href use UUID...
larowlan’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.