At this moment every link widget items is a link with plain text in it.

We should add wrappers around the count and disable-link, so themers can target these for specific theming.

For the checkboxes widget we will be extending from the links widget. In this case its also necessary to be able to target those specific elements.

Comments

StryKaizer created an issue. See original summary.

StryKaizer’s picture

Issue summary: View changes
StryKaizer’s picture

Tests are locally still running, prolly need to fix some stuf in those before this will go green.

Status: Needs review » Needs work

The last submitted patch, 3: links_widget_should-2713137-3.patch, failed testing.

The last submitted patch, 3: links_widget_should-2713137-3.patch, failed testing.

StryKaizer’s picture

Fixed some tests... Still need to fix more though, lets see how much

Status: Needs review » Needs work

The last submitted patch, 6: links_widget_should-2713137-6.patch, failed testing.

The last submitted patch, 6: links_widget_should-2713137-6.patch, failed testing.

borisson_’s picture

Status: Needs review » Needs work

The last submitted patch, 9: links_widget_should-2713137-9.patch, failed testing.

The last submitted patch, 9: links_widget_should-2713137-9.patch, failed testing.

borisson_’s picture

Less specific assertion - should resolve that one remaining failure.

StryKaizer’s picture

Status: Needs review » Reviewed & tested by the community

Looks good, committing

  • StryKaizer committed 5291e21 on 8.x-1.x
    Issue #2713137 by borisson_, StryKaizer: Links widget should provide...
StryKaizer’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.