At this moment every link widget items is a link with plain text in it.

We should add wrappers around the count and disable-link, so themers can target these for specific theming.

For the checkboxes widget we will be extending from the links widget. In this case its also necessary to be able to target those specific elements.

CommentFileSizeAuthor
#12 links_widget_should-2713137-12.patch15.1 KBborisson_
#12 interdiff.txt1.06 KBborisson_
#9 links_widget_should-2713137-9.patch15.25 KBborisson_
#9 interdiff.txt15.01 KBborisson_
#6 links_widget_should-2713137-6.patch5.57 KBstrykaizer
#3 links_widget_should-2713137-3.patch1.12 KBstrykaizer

Comments

StryKaizer created an issue. See original summary.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Issue summary: View changes
strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Active » Needs review
StatusFileSize
new links_widget_should-2713137-3.patch1.12 KB

Tests are locally still running, prolly need to fix some stuf in those before this will go green.

Status: Needs review » Needs work

The last submitted patch, 3: links_widget_should-2713137-3.patch, failed testing.

The last submitted patch, 3: links_widget_should-2713137-3.patch, failed testing.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Needs work » Needs review
StatusFileSize
new links_widget_should-2713137-6.patch5.57 KB

Fixed some tests... Still need to fix more though, lets see how much

Status: Needs review » Needs work

The last submitted patch, 6: links_widget_should-2713137-6.patch, failed testing.

The last submitted patch, 6: links_widget_should-2713137-6.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt15.01 KB
new links_widget_should-2713137-9.patch15.25 KB

interdiff w/ #3.

Status: Needs review » Needs work

The last submitted patch, 9: links_widget_should-2713137-9.patch, failed testing.

The last submitted patch, 9: links_widget_should-2713137-9.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.06 KB
new links_widget_should-2713137-12.patch15.1 KB

Less specific assertion - should resolve that one remaining failure.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Needs review » Reviewed & tested by the community

Looks good, committing

  • StryKaizer committed 5291e21 on 8.x-1.x 
    Issue #2713137 by borisson_, StryKaizer: Links widget should provide...
strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.