Problem/Motivation

behat/mink 1.7.0 and behat/mink-goutte-driver 1.3.0 are not compatible with Symfony 3.

Proposed resolution

Update behat/* so that we can update to Symfony 3 later on.

Remaining tasks

Fix fails.
Review.
Commit.

User interface changes

None

API changes

Hopefully none

Data model changes

Not yet

CommentFileSizeAuthor
#13 update_behat_to_1_7_1-2712643-13.patch7.52 KBjibran
#4 update_behat_mink_to-2712643-4.patch7.73 KBjibran
#2 update_behat_mink_to-2712643-2.patch6.09 KBjibran

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs review
StatusFileSize
new update_behat_mink_to-2712643-2.patch6.09 KB

Here is the patch.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Parent issue: » #2712647: Update Symfony components to ~3.2
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new update_behat_mink_to-2712643-4.patch7.73 KB

Ran the following command.

composer update behat/* fabpot/goutte
You are running composer with xdebug enabled. This has a major impact on runtime performance. See https://getcomposer.org/xdebug
Loading composer repositories with package information
Updating dependencies (including require-dev)
  - Removing fabpot/goutte (v3.1.1)
  - Installing fabpot/goutte (v3.1.2)
    Loading from cache

> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Removing behat/mink (v1.7.0)
  - Installing behat/mink (v1.7.1)
    Loading from cache

> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Removing behat/mink-browserkit-driver (v1.3.0)
  - Installing behat/mink-browserkit-driver (v1.3.2)
    Loading from cache

> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Removing behat/mink-goutte-driver (v1.2.0)
  - Installing behat/mink-goutte-driver (v1.2.1)
    Loading from cache

> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
Writing lock file
Generating autoload files
> Drupal\Core\Composer\Composer::preAutoloadDump
> Drupal\Core\Composer\Composer::ensureHtaccess
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community
dawehner’s picture

dawehner
Primary language German
commented
Title: Update behat/mink to 1.7.1 » Update behat/* to 1.7.1 and fabpot/goutte to 3.1.2
catch’s picture

catch
he/him
Primary language English
commented
Version: 8.2.x-dev » 8.1.x-dev

Committed 632d3c2 and pushed to 8.2.x. Thanks!

Since this only affects tests, we might want to commit to 8.1.x - moving there but leaving RTBC for now.

  • catch committed 3d404ae on 8.2.x 
    Issue #2712643 by jibran: Update behat/* to 1.7.1 and fabpot/goutte  to...
catch’s picture

catch
he/him
Primary language English
commented

If I do commit to 8.1.x, will probably do it shortly after 8.1.1 just for paranoia's sake regarding drupalci stability.

catch’s picture

catch
he/him
Primary language English
commented
Assigned: Unassigned » catch

Assigning this to me so that there's some indication of why it's at RTBC - given we can't show there's already a commit against 8.2.x.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: update_behat_mink_to-2712643-4.patch, failed testing.

The last submitted patch, 4: update_behat_mink_to-2712643-4.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new update_behat_to_1_7_1-2712643-13.patch7.52 KB

Passing patch against 8.1.x.

  • catch committed 99443e1 on 8.1.x 
    Issue #2712643 by jibran: Update behat/* to 1.7.1 and fabpot/goutte  to...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.