Closed (fixed)
Project:
Drupal core
Version:
8.2.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
24 Apr 2016 at 23:13 UTC
Updated:
1 Aug 2016 at 17:52 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
jibranHere is the patch.
Comment #3
jibranComment #4
jibranPostponing it on https://github.com/stackphp/builder/issues/21.
Comment #5
simensen commentedI'll try to get this issue w/ stack/builder resolved this week.
Comment #6
klausiDo we have to wait on the stackphp release or can we just use dev-master in composer.json? I forgot if we have a policy about non-stable dependencies in composer, do we have a doc page or something else for that?
Alternatively we can just fork stackphp and make our own stable release, but I think depending on a dev version is the lesser evil.
Comment #7
dawehnerI don't think we have a policy around that. IMHO creating a fork with different stable versions would be just more confusing.
Comment #8
jibranI left a message for @simensen on the related issue on github.
Comment #9
dawehnerIMHO we should not have to wait for an upstream release, but I'm not sure whether there might be a policy around that.
Comment #10
klausiAgreed, so let's go ahead with the dev version in composer.json.
Patch does not apply anymore, rerolled. I also added the specific git hash to composer.json to make sure people always get this version when they mess with composer update.
IMO this is RTBC, can someone double check and change the status.
Comment #11
klausiFixed issue summary.
Comment #12
dawehnerGood idea!
Comment #13
jeroentA new release is tagged: https://github.com/stackphp/builder/issues/21.
Comment #14
simensen commentedI apologize on the delay for this. Life happened and I'm in the process of getting someone else to help maintain StackPHP going forward. Hopefully this will get you unstuck for now but if there are issues with this build let me know and I'll see if I can get around to it more quickly this time around.
Thanks for your patience.
Comment #15
klausiCool, so we only need to update composer.lock.
Comment #16
klausiComment #17
dawehner@simensen
No worries, life is always more important than this opensource thing. Thanks a ton!
It's cool to see when the version updates are actually small!
Comment #19
catchCommitted/pushed to 8.2.x, thanks!
Comment #21
webchickSince this paves the way for Symfony 3, may be worth calling out in the release notes.