When you have language prefixes on a multilanguage site, facets are using the wrong urls.

CommentFileSizeAuthor
#9 language_prefix_breaks-2712557-9.patch1.93 KBborisson_
#9 interdiff.txt808 bytesborisson_
#7 language_prefix_breaks-2712557-7.patch1.76 KBborisson_
#7 interdiff.txt1.45 KBborisson_
#6 language_prefix_breaks-2712557-6.patch1.96 KBborisson_
#6 interdiff.txt422 bytesborisson_
#4 language_prefix_breaks-2712557-4.patch1.98 KBborisson_

Comments

StryKaizer created an issue. See original summary.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Priority: Major » Critical
strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Issue tags: +beta blocker
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Active » Needs review
StatusFileSize
new language_prefix_breaks-2712557-4.patch1.98 KB

I can't reproduce this issue, but I couldn't verify that in the test with assertUrl, the current code (w/ strpos) does agree with me though. I think we can commit the test and close the issue?

Status: Needs review » Needs work

The last submitted patch, 4: language_prefix_breaks-2712557-4.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt422 bytes
new language_prefix_breaks-2712557-6.patch1.96 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
StatusFileSize
new interdiff.txt1.45 KB
new language_prefix_breaks-2712557-7.patch1.76 KB

Took another look at the patch.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Needs review » Needs work

Maybe add to the test that the results are still as expected in the end. It could still show a page not found too now.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new interdiff.txt808 bytes
new language_prefix_breaks-2712557-9.patch1.93 KB

Sure, that makes sense.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Needs review » Reviewed & tested by the community

Great!

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.