I successfully added Fastly as a CDN for serving static content but theres one problem after enabling the CDN module:
File upload is not possible anylonger.
The following error occurs on file upload:
InvalidArgumentException: The URI '//example.com/sites/default/files/2016-04/Scan.jpeg' is invalid. You must use a valid URI scheme. in Drupal\Core\Url::fromUri() (line 306 of /home/r0ea6/www/core/lib/Drupal/Core/Url.php).
Steps to reproduce :
Proposed resolution:
Only alter the file base path on view not on upload.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | 2711529-12.patch | 725 bytes | wim leers |
Comments
Comment #2
wim leersThis is due to a documented core bug. From the alpha1 release notes:
But it's probably good to track it in the CDN module issue queue as well, so thanks for that
Comment #3
wim leersi.e. please help review #1783278: Scheme-relative URL rejected by validation.
Comment #4
yobottehg commentedjust to be extra safe, this will probably solve the error, but the file upload still goes to the wrong url i think.
I my use case i serve all static assets via a fastly domain but uploads should still be done using the default domain.
So from my point of view CDN should not alter the domain while uploading a file.
Comment #5
yobottehg commentedokay i was wrong.
The patch fixes the problem.
Comment #6
wim leersYes. Everything in #4 is speculation, which as it turns out, is wrong :) If it were correct, then I'd agree with you that that would be bad!
Comment #7
wim leersComment #8
wim leersLooks like this will actually be fixed in #2573635: Url::fromUri() should accept protocol-relative URLs now.
Comment #9
wim leersClosed #2734859: When I save a node - I get an error 500 as a duplicate of this one.
Comment #10
wim leersYay, #2573635: Url::fromUri() should accept protocol-relative URLs landed, which means that once Drupal 8.1.3 is released and people start using that version, this problem will be a thing of the past!
Comment #11
wim leersThis patch makes the CDN module require Drupal 8.1.3.
Updated relevant core issues: #2313917-67: Core version key in module's .info.yml doesn't respect core semantic versioning and #2641658-22: Module version dependency in .info.yml is ineffective for patch releases.
Comment #12
wim leersComment #13
wim leersAlso updated
composer.jsonper https://getcomposer.org/doc/articles/versions.md.Comment #14
webflo commentedPatch #12 is good to go. A dedicated composer.json is not necessary for internal (drupal modules and themes) dependencies.
Comment #15
wim leersThanks for your confirmation, @webflo!
I'll remove the CDN module's
composer.json.Comment #17
wim leersComment #18
wim leers8.1.3 was released yesterday, but it doesn't include this. Because it's a security release that doesn't contain anything except for the security fixes.
So, I was a bit too quick. It's probably going to be 8.1.4, but let's not make the same mistake again. Postponing this issue on the 8.1.4 release that will likely include this fix.
Comment #19
wim leersAnd now this fix has indeed made it into the 8.1.4 release: https://www.drupal.org/project/drupal/releases/8.1.4.
Comment #21
wim leers