Custom attributes in blocks

I attempted to install this but I still don't see any options to add classes and ids.

This fixes regression otoh maybe better to implement more generic on top of https://www.drupal.org/project/styles_api

I also do not see any options to add classes and ids. If I have some time, I'll take a closer look.

Don't hack related issues

@andypost Sorry about that. The removal of the related issue was unintentional. Thanks for catching that and adding it back.

This appeared to be not working.

This appears not to be working per @heshnlk said.

The problem seems that the settings does actually exist at the "Edit Block" level.

But when you load them through PageBlockDisplayVariant->buildRegions it builds the configuration array without the css (or the new custom) attributes.

any idea why this is going on?

Actually this page_manager-block-css-attributes-9.patch does work.

I totally missed that i should have clicked "update & save" to save the tempstore into the configuration.

Thanks for the efforts @mistermope

Patch page_manager-block-css-attributes-9.patch worked nice for new module installations. However, it required hook_update_N() for existing page manager config.

New patch loops through existing page variant config and amends block settings where needed.

I have been using #9 for a while and it's working great for me (real help), I think @bbujisic #21 just perfected it. Any reason we are not merging this yet?

+++ b/page_manager.install
@@ -32,3 +32,24 @@ function page_manager_requirements($phase) {
+      if (empty($block['css_classes'])) {
+        $block['css_classes'] = '';
+      }
+      if (empty($block['css_id'])) {
+        $block['css_id'] = '';
+      }
+      $config->set('variant_settings.blocks.' . $block_id, $block);
+    }
+    $config->save(TRUE);
+  }
+}
\ No newline at end of file

I'm sure, resave should happens only when both properties is unset.

+ needs newline at the end file

Fix #23 and reroll to 8.x-4.x

For some reason there is no option to run 4.x tests on drupal.org

I have applied the last patch and I don't see the fields Css classes and Css ID
I have tried to run update.php at it don´t find any update. Of course I´ve deleted cache with drush cr
My Page Manager version is 8.x-4.0-beta2

Thanks in advanced

If i understand correctly this issue is about adding custom attributes in the Panelizer UI forms. I don't see any reference however to being able to add / edit custom attributes while using panels IPE. Would it be an option to expand the scope of this issue to also implement this?

Reroll #24 on top of latest commit (8.x-4.0-rc3)