Remove sms_incoming_queue_worker() function. Function was made obsolete by #2677682: SMS message FIFO dispatch queue
Remove sms_incoming.inc file . This file has not been upgraded to D8, and shouldnt be required due to D8's new router system?
Remove sms_incoming() function. Refer users of this function to $provider->queue().

Remaining usages in SMS Framework:

  • 1x sms_devel: SendForm.php
  • 1x sms.module sms_incoming_queue_worker - obsolete
  • 1x sms_devel: sms_devel_virtualgw_receiver()
CommentFileSizeAuthor
#8 remove-sms_incoming-2709925-8.patch31.67 KBdpi
#2 remove-sms_incoming-2709925.patch13.7 KBdpi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dpi created an issue. See original summary.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Status: Active » Needs review
FileSize
remove-sms_incoming-2709925.patch13.7 KB

https://github.com/dpi/smsframework/pull/31

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented

What are your current opinions on sms.parser.inc, sms_incoming.inc, BootStrapAdminForm?

Its been over a year since they were touched. Is it necessary for SMS Framework to implement a shortcut for gateways, or is the work required for gateways small enough for them to do it on their own?

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Issue tags: +beta blocker

Tagging.

API change and/or schema change.

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented

I was thinking of using a stack middleware to implement the bootstrap functionality, the purpose which was to allow incoming messages to be passed straight to gateways without having to fully bootstrap Drupal.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented

I havnt looked into such Drupal functions before

Is everything removed in the PR safe? and #2716419: Remove sms.parser.inc ? are we recycling anything?

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented

I've looked at this again, and I think if we ever need this functionality again, it can be easily implemented in D8 with the current capabilities. I don't really know what sms.parser.inc was supposed to parse, but it seems there was this concept of having keyword based mobile-originated SMS receivers and parsers. This is what SMS Actions module is primarily doing - it allows old Drupal 6 / 7 triggers to be defined based on the keywords in a received SMS and then these triggers can be linked to actions.

I will make a meta issue that ties all these bits together.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
FileSize
remove-sms_incoming-2709925-8.patch31.67 KB

rerolld

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented

This is what SMS Actions module is primarily doing - it allows old Drupal 6 / 7 triggers to be defined based on the keywords in a received SMS and then these triggers can be linked to actions.

Hold onto that thought: #2641888: Port SMS Actions to Drupal 8 #comment-11199679

  • dpi committed 8f5206c on 8.x-1.x 
    Issue #2709925 by dpi: Remove unused incoming functionality
dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.