Problem/Motivation
Part of #2396201: [meta] Update 8.x-1.x branch to match core 8.0.1, SMS Actions has not yet been ported to Drupal 8.
Proposed resolution
Port SMS Actions to Drupal 8
Remaining tasks
Patch
Reviews
Commit
User interface changes
None
API changes
None
Data model changes
All the settings schema needed to port the module.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | port_sms_actions-2641888-5.patch | 33.37 KB | almaudoh |
Comments
Comment #2
almaudoh commentedWorking on this now...
Comment #3
dpiI think it might be worth converting existing core actions to Rules actions.
The Drupal action system is not great, and is not good enough for Rules (#2501929: Separate the Rules actions API from core). Action plugins never got a formal context system like conditions received.
Comment #4
dpiI think this should be postponed until Rules matures, or at least receives a full UI.
Comment #5
almaudoh commentedI've had this done for a while waiting for the Rules module to get to Milestone 2. Just uploading to show progress...
Comment #6
dpiThis submodule should be updated or removed before beta.
Since this module is a nontrivial endeavor, do you anticipate being api-stable by ~July?
Comment #7
almaudoh commentedConsidering that SMS Actions is a misnomer for what the module actually does. I'm going to re-purpose this issue to provide mobile-originated SMS receipt and parsing, which will later on be integrated with Rules after #2712599: [meta] Rules integration is in.
This issue is going to be primarily about implementing keyword based D8 Conditions, hence the module will also be renamed to SMS Conditions [subject to bike-shedding :)]
Re-rolled patch above https://github.com/almaudoh/smsframework/pull/7/files
Edit: updated PR link
Comment #8
almaudoh commentedComment #9
dpiFrom #2709925: Remove sms_incoming() and sms_incoming.inc #8
Comment #10
dpire: #9
Are you saying that sms_actions is what I was doing with sms_user incoming messages (placeholders etc) ?
Sorry I don't think I actually looked into sms_actions properly then...
Comment #11
almaudoh commentedCan't remember what you were doing there...maybe post a link to a PR or commit??
Comment #12
dpiIt sounds like the placeholder system I implemented for
\Drupal\sms_user\AccountRegistration./admin/config/smsframework/sms_user_options -> Pre-formatted message.
AccountRegistration::preFormattedMessageComment #13
dpiI was thinking about making that placeholder system a registry for the core module, then when an incoming message with that pattern is found it is routed to the correct callback .
Comment #14
almaudoh commentedYeah. It's the same kind of thing, but yours looks more flexible and capable.
The SMS Actions one was just in the format of:
Then an action will be triggered if discriminant matches a specified value and the whole text content will be sent as context to the triggered action.
Comment #15
almaudoh commentedWe can design and develop an entire system for handling incoming messages based on a pre-defined format. The Conditions system is a good way to go.
I actually implemented a custom module for a site that had the same functionality (and more stuff) long before I saw it in SMS Actions. So this is an indication that a generic implementation would be widely useful.
Comment #16
almaudoh commentedWe can do this in 1.1 I think.
Comment #17
dpiComment #18
dpiRelevant to comments #10-15: #2786799: Add pattern-matching incoming message routing system
Comment #19
almaudoh commentedI suggest this be done in a separate module entirely outside of SMS Framework.
Comment #20
dpi