When changing a field's type from "fulltext" to something else, the field should be removed from some processor configurations (e.g., tokenizer).

CommentFileSizeAuthor
#7 2709351-7--field_type_change_processor_config_update.patch5.22 KBdrunken monkey
#7 2709351-7--field_type_change_processor_config_update--tests_only.patch2.21 KBdrunken monkey

Comments

StryKaizer created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Component: General code » Framework

Just tried it out myself and could indeed reproduce the problem. A bit of debugging revealed that this was caused by the "Tokenizer" processor, which was still set to work on this field, even though it should never be active for string fields. Re-saving the "Processors" form without any changes fixed the problem for me.

Could you try whether this is also the case for you? Then I guess the issue would be to react to field changes with the processors, or to ensure processors check the field type again before running – or both.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented

After saving the processors form, for me it also works again.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Title: Field is not indexed after changing field type » Processors should be able to react to changed fields
Category: Bug report » Task
Issue summary: View changes
Issue tags: +beta blocker

Damn, then that's another thing to be solved in the framework before we can call it stable.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Title: Processors should be able to react to changed fields » Update processor configurations when field types change
Category: Task » Bug report
Issue summary: View changes
Issue tags: -beta blocker

Oh, nevermind, we do have preIndexSave() already.
Just need to implement it for whichever processor needs to, and probably add some tests.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Issue tags: +Release blocker
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 2709351-7--field_type_change_processor_config_update--tests_only.patch2.21 KB
new 2709351-7--field_type_change_processor_config_update.patch5.22 KB

Pretty straight-forward, but should fix that problem nicely. (Also, I guess a similar problem exists when removing fields from the index? Is fixed with this patch, too.)

The last submitted patch, 7: 2709351-7--field_type_change_processor_config_update--tests_only.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

  • drunken monkey committed 5a33829 on 8.x-1.x 
    Issue #2709351 by drunken monkey: Fixed invalid processor configurations...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.