Problem/Motivation

hook_help() should only return a string when adding help text. This causes a visual issue in bartik because the help block is unnecessarily displayed and has a border.

Proposed resolution

Do an early return in hook_help().

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 2707105-2.patch699 bytesalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2707105-2.patch699 bytes

I don't think this issue is worth a test. OTOH it might be worth opening a core issue to treat an empty string and NULL as the same thing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Related issues: +#2707109: Help block should not be displayed when hook_help() implementations return an empty string

So this is a regression from Drupal 7 - opened #2707109: Help block should not be displayed when hook_help() implementations return an empty string

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Looks like the core issue was already fixed, but that doesn't look like a reason to not do this.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Closed (duplicate)

#2725577: Improve redirect_help() already fix this as well.