Port to Drupal 8

Hello,

Yes, probably it's a good idea to port it to D8. Although at the moment you're the only one who has raised this subject. I guess Term Merge is for 1 year+ kind of websites and D8 hasn't got yet so much distance behind it, so people still do not care about merging/purging their databases :)

I am cleaning up and bringing up to date 7x modules I maintain at drupal.org, once that is done (should be in a month or so, I hope), I'll look into porting them into Drupal 8. Maybe Term Merge won't be the 1st one among them (for the other modules there are at least half a dozen of folks asking for it per each module), but yeah, why not.

hello! Congratulations on the full project! :) I know it's not that easy to pass Drupal review process when one tries to promote his sandbox into a full project.

In the meantime I had an opportunity to get some hands on experience with developing a D8 module, so I guess I am slowly moving into this direction.

By the way, would you like your module included on the description page of Term Merge module? I could add some extra bullet point saying there is also such module that integrates with TermMerge?

I've added your module into the description of Term merge.

I've started a port of Term Merge to Drupal 8. I'm currently hosting the repo on github and once I've got something worth sharing, I'll share the repo. I'm hoping it won't be too much of an effort to port it! Will keep you all updated.

Updated repo to: https://www.drupal.org/sandbox/welly/2808469

Opened up an issue on the contrib issue tracker at https://www.drupal.org/node/2808975

Hello,

I've reviewed your sandbox. I am still rather beginner with D8 (and god knows they've put lots of new things to learn for us in D8), but here's what I'd like to share:

• First of all I would clean up from D7 remaining (License.txt, *.info, term_merge.module.php contains D7 code, etc)
• Originally I was thinking whether we shouldn't take the opportunity of this inevitable re-write and make it from "term merge" to "entity merge"? So any kind of content entity can be merged?
• D8 heavily leverages dependency injection. So I feel that creating a global TermMerge::merge() is too intrusive. Shouldn't we instead provide a service (via term_merge.services.yml) that can be injected wherever needed?
• I would also prefer to introduce new plugin types (one for specifying branch terms and another for specifying trunk term), so folks outside of Term Merge module can introduce their own widgets for these purposes. In fact my experience of maintaining this module tells that it's such a versatile task and there are so many cases, that hardly 1 single widget will fit everybody's needs (however, everybody wants to leverage the rest of Term Merge features), so if we give them relatively easy way to "hook in" in the widget part, they should be happy :)
• Lastly, I would also make the cTools "duplicate_suggestion" plugin type from D7 as a new D8 plugin type. Again, same logic applies: purging your terms is such a context-rich task, that often the definition of "duplicate" varies significantly, so if we let developers from outside to "hook in" at what defines a duplication, they'll again be happy :)

I'll try to get going with this D8 rewrite since I need to improve my D8 skills :)

Hi bucefal91,

There's still a lot to go on my port, bit too early for a review but thanks for your comments all the same. I shall certainly take them onboard! Some good advice there. My intention was just to get something working initially as we needed to use this module in house and then look at improving it. Anyway, I'll keep at it.

Cheers!

I've been coding the action for D8 version as that's the innermost piece of Term Merge module, however, came across this weird behavior. I reported it as a bug against core. Let's see what they say: #2816861: Action configuration form does not support #ajax

For those in need of simple merge module for D8 I wrote a simple one for my use case and shared it
https://www.drupal.org/project/simple_entity_merge

If you find it useful please contribute :)

Drupal 8 branch has been opened and contains a basic implementation. Please check it out and provide feedback.