Add a flag for gateways indicating that the gateway service is capable of delaying SMS messages on its end, so it does not require SMS Framework to artificially defer transmission.

For example, Clickatell provides this facility: How do I schedule my SMS messages?

Implementation

SMS Framework will try to send all SMS messages regardless of send_on date. The schedule-aware gateway is then responsible for extracting the getSendTime() value from the message.

This feature has a dependency on #2677682: SMS message FIFO dispatch queuehttps://www.drupal.org/node/2705079#

CommentFileSizeAuthor
#4 schedule-aware-2705079-4.patch7.17 KBdpi
#2 schedule-aware-2705079.patch7.09 KBdpi

Comments

dpi created an issue. See original summary.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Active » Needs review
StatusFileSize
new schedule-aware-2705079.patch7.09 KB

https://github.com/dpi/smsframework/pull/33

Not a particularly exciting PR.

Complete with tests, and a fix to to the createMemoryGateway helper

Status: Needs review » Needs work

The last submitted patch, 2: schedule-aware-2705079.patch, failed testing.

dpi’s picture

dpi
Location Perth, Australia
commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new schedule-aware-2705079-4.patch7.17 KB

Fixed missing return from test gateway.

almaudoh’s picture

almaudoh commented

Looking at this...

  • dpi committed 179f4d5 on 8.x-1.x 
    Issue #2705079 by dpi: Added schedule-aware flags for gateways
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs review » Fixed
almaudoh’s picture

almaudoh commented 
+      if (!$sms_gateway->isScheduleAware()) {
+        $query->condition('send_on', REQUEST_TIME, '<=');
+      }

This bit of code doesn't have test coverage.

dpi’s picture

dpi
Location Perth, Australia
commented

This bit of code doesn't have test coverage.

SmsFrameworkQueueTest::testQueueDelayed

That code existed before this patch, its now added conditionally

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.