This patch upgrades Zurb Foundation to 6.2, in addition to bringing @bcwald's Gulp work back to the base theme.

I haven't touched the templates yet, so we'll need to make sure that features like the Top Bar still work before committing this.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

samuel.mortenson created an issue. See original summary.

samuel.mortenson’s picture

FileSize
1.65 MB
3.92 KB

Updated patch, which fixes SASS compilation errors in the subtheme as well as fixing off-canvas (which currently does not work. Top bar, sticky, nested menus, and the mobile menu icon all seem to work.

Please review so we can get this in!

HongPong’s picture

A couple notices I got at `bower install` worth looking at resolving:

bower invalid-meta  The "name" is recommended to be lowercase, can contain digits, dots, dashes

Unable to find a suitable version for jquery, please choose one by typing one of the numbers below:
    1) jquery#~2.1.4 which resolved to 2.1.4 and is required by motion-ui#1.1.1
    2) jquery#~2.2.0 which resolved to 2.2.3 and is required by foundation-sites#6.2.1

Drupal 8.0.6 is distributed with jQuery 2.1.4. I think it should be okay if 2.2.3 is running instead.

I changed the dependency versions to

    "foundation-sites": "~6.2.1",
    "motion-ui": "~1.2.2"

which unifies the jquery requirement to 2.2.3. Also changed the bower "name" to avoid complaints from system. I also added a little more helpful info to the gulpfile to clue the developer in to what it's doing.

Also I checked out all the settings with topbar and it seems like they come through OK as long as you make sure to rebuild the cache, it can stick to the top of the browser window correctly including when the administrative menu is stuck there, it attaches right under it correctly for admins.

samuel.mortenson’s picture

Thanks for updating the version - to prevent this in the future we should ignore jQuery as a dependency (which we already did in the STARTER theme). This patch updates the STARTER theme's dependencies to match the base theme as well as ignoring jQuery in the base theme.

HongPong’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Foundation 6

I got the following notices regarding various packages, however these are not due to problems in the theme itself.

npm WARN deprecated graceful-fs@3.0.8: graceful-fs version 3 and before will fail on newer node releases. Please update to graceful-fs@^4.0.0 as soon as possible.
npm WARN deprecated lodash@1.0.2: lodash@<3.0.0 is no longer maintained. Upgrade to lodash@^4.0.0.
npm WARN deprecated graceful-fs@1.2.3: graceful-fs version 3 and before will fail on newer node releases. Please update to graceful-fs@^4.0.0 as soon as possible.
npm WARN deprecated npmconf@2.1.2: this package has been reintegrated into npm and is now out of date with respect to npm
npm WARN prefer global node-gyp@3.3.1 should be installed with -g

the lodash and graceful-fs warning is from here:

│ └─┬ vinyl-fs@0.3.14
│   ├── defaults@1.0.3
│   ├─┬ glob-stream@3.1.18
│   │ ├── glob@4.5.3
│   │ ├─┬ glob2base@0.0.12
│   │ │ └── find-index@0.1.1
│   │ ├── minimatch@2.0.10
│   │ ├── ordered-read-streams@0.1.0
│   │ ├─┬ through2@0.6.5
│   │ │ └── readable-stream@1.0.34
│   │ └── unique-stream@1.0.0
│   ├─┬ glob-watcher@0.0.6
│   │ └─┬ gaze@0.5.2
│   │   └─┬ globule@0.1.0
│   │     ├─┬ glob@3.1.21
│   │     │ ├── graceful-fs@1.2.3
│   │     │ └── inherits@1.0.2
│   │     ├── lodash@1.0.2
│   │     └── minimatch@0.2.14

The notice on npmconf derives from gulp-sass@2.3.1 and node-sass@3.5.3.

Anyhow I think we can call this RTBC, as it is a big patch and npm packages are not immediately a blocking problem. I will try to have a better README.txt patch tomorrow that reflects the new workflow, as seen in the STARTERKIT readme. Gotta love those sprawling npm dependency trees. I'm sure their noise will alarm Drupal devs forever now.

  • samuel.mortenson committed f4e637d on 8.x-6.x
    Issue #2702271 by samuel.mortenson, HongPong: Update Zurb Foundation to...
samuel.mortenson’s picture

Status: Reviewed & tested by the community » Fixed

Done!

I accidentally pushed the wrong commit message and had to do a merge as Drupal.org won't let you force push after amending a commit message, but you should have the commit credit now.

HongPong’s picture

Sweet thanks for throwing that in there. Tag me on anything that blocks an alpha release for the next week or so I can try to knock out. Cheers

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.