Closed (fixed)
Project:
Lightweight Directory Access Protocol
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 Apr 2016 at 12:52 UTC
Updated:
24 May 2016 at 22:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
larowlanLooking good - thanks!
Some white space here
Can we import the FQCN and use the short name here?
D8 will do this for us now
We should use $field->getMainPropertyName instead of inspecting the columns ourself. However, again D8 does this for us, so we can use
$user->{$field_name} = $valuesComment #3
queenvictoria commentedI've taken a bash at your recommendations @larowlan as this was on my list of things to do too. Please see if I've done it correctly. It does seem to at least store the configuration.
Also (and I've come across this before) is there a Drupal 8 way to have an "add another row" button rather than a suite of empty rows?
Comment #4
queenvictoria commentedOk so I wasn't close at all with that.
I've majorly reworked LdapUserConf->entryToUserEdit() to use $account objects rather than $edit arrays. This is because it is used both by create and edit functions. And Drupal 8 doesn't seem to have an equivalent to user_save($account, $edit).
So its a massive patch and requires the patch that switches to using the external_auth module to replace the user->data column that was retired in Drupal 8.
https://www.drupal.org/node/2698157
Comment #5
queenvictoria commentedSo I neglected to include the changes from @manuel.adan and this patch is now very tangled with the patch from https://www.drupal.org/node/2698157. I will upload a combined version now and then try to undo the entanglement.
Comment #6
queenvictoria commentedOk I've also moved "LDAP user properties (PUID, DN...) not saved or updated" in to here and closed that issue.
I've unentangled https://www.drupal.org/node/2698157
Here is a patch that should do the job.
Comment #8
queenvictoria commentedOk committed to a9bebf7ac79203a22b616f67fc71e0bd5cb700cd.