Out there in #2655044: Add "Text overlay" image effect, I forgot to move from Textimage the hook_requirements() implementation in .install that checks for GD FreeType support, needed by the 'Text overlay' effect.

Doing it here. However, I am suggesting to only raise a warning at install/runtime, not an error like in Textimage - IMO it would be too strict to prevent the entire module to get installed. To avoid possible fatals, I am introducing two wrapper methods to imagettftext and imagettfbbox that check for the function existence, and if not, raise an exception that gets logged.

CommentFileSizeAuthor
#4 2701057-4.patch6 KBmondrake
#4 interdiff_2-4.txt2.12 KBmondrake
#2 2701057-2.patch4.7 KBmondrake

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
StatusFileSize
new 2701057-2.patch4.7 KB

Patch

fietserwin’s picture

fietserwin
Location Le Mont-Dore
commented 
+++ b/src/Plugin/ImageToolkit/Operation/gd/GDOperationTrait.php
@@ -145,4 +145,40 @@ trait GDOperationTrait {
+  /**
+   * Wrapper of imagettftext().
+   *
+   * If imagettftext() is missing, throw an exception instead of failing
+   * fatally.
+   */
+  protected function _imagettftext($image, $size, $angle, $x, $y, $color, $fontfile, $text) {

Should we add @param and @return, for better type checking and auto-completion? Same for _imagettfbox().

For the rest it's OK.

mondrake’s picture

mondrake
Location 🇮🇹
commented
StatusFileSize
new interdiff_2-4.txt2.12 KB
new 2701057-4.patch6 KB

Thanks @fietserwin, done + added @see to PHP docs.

fietserwin’s picture

fietserwin
Location Le Mont-Dore
commented
Status: Needs review » Reviewed & tested by the community

Go ahead.

slashrsm’s picture

slashrsm commented
Status: Reviewed & tested by the community » Fixed

Committed.

  • slashrsm committed cd16c28 on 8.x-1.x authored by mondrake 
    Issue #2701057 by mondrake, fietserwin: GD FreeType library requirements...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.