When the response is- 404 Page Not Found and the 404 page is being rendered by fast 404 module. Drupal should not bootstrap completely as the result of the fast 404 module.

CommentFileSizeAuthor
#16 2700857.patch1.74 KBnaveenvalecha
#13 stop-bootstrapping-2700857-13.patch1.34 KBsdstyles
#5 stop_drupal_from-2700857-5.patch1.12 KBneetu morwani
#2 stop_drupal_from-2700857-2.patch666 bytesneetu morwani

Comments

neetu morwani created an issue. See original summary.

neetu morwani’s picture

neetu morwani commented
StatusFileSize
new stop_drupal_from-2700857-2.patch666 bytes
neetu morwani’s picture

neetu morwani commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: stop_drupal_from-2700857-2.patch, failed testing.

neetu morwani’s picture

neetu morwani commented
StatusFileSize
new stop_drupal_from-2700857-5.patch1.12 KB

Patch updated. Repo cloned from d.o

neetu morwani’s picture

neetu morwani commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 5: stop_drupal_from-2700857-5.patch, failed testing.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Parent issue: » #2700857: Stop Drupal from bootstrapping once the page is not found
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Parent issue: #2700857: Stop Drupal from bootstrapping once the page is not found » #2715027: Fast 404 8.x-2.x-beta1
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Assigned: neetu morwani » naveenvalecha
Issue tags: +Novice, +Needs reroll

assigning to myself to give it a run.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Assigned: naveenvalecha » Unassigned

This needs a reroll as this went in #2462337: To support PHP 7 we can no longer have a class named "String"

naveenvalecha’s picture

naveenvalecha
He/Him
commented 
+++ b/src/Fast404.php
@@ -138,7 +139,8 @@ class Fast404 {
+    exit();

Don't use the exit function. let's use the EventSubscriber GetResponseEvent $event object to do that for you.

use the $event->setResponse() in onKernelRequest to send the request.

sdstyles’s picture

sdstyles commented
Status: Needs work » Needs review
StatusFileSize
new stop-bootstrapping-2700857-13.patch1.34 KB

Status: Needs review » Needs work

The last submitted patch, 13: stop-bootstrapping-2700857-13.patch, failed testing.

sdstyles’s picture

sdstyles commented
Status: Needs work » Needs review
StatusFileSize
new stop-bootstrapping-2700857-15.patch1.04 KB

Reroll patch after changes from response() method.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Issue tags: -Needs reroll
StatusFileSize
new 2700857.patch1.74 KB

The last submitted patch, , failed testing.

Status: Needs review » Needs work

The last submitted patch, 16: 2700857.patch, failed testing.

neetu morwani’s picture

neetu morwani commented

Manual testing of the functionalities delivered by the module is done. Everything seems fine. Drupal doesn't get bootstrapped when a page is not found.
Patch looks good to me.
Thanks.

neetu morwani’s picture

neetu morwani commented
Status: Needs work » Needs review
neetu morwani’s picture

neetu morwani commented
Status: Needs review » Reviewed & tested by the community

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x-1.x
Will be included in next release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.