Closed (fixed)
Project:
Panels
Version:
8.x-3.x-dev
Component:
In-Place Editor (IPE)
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
2 Apr 2016 at 16:06 UTC
Updated:
21 Apr 2017 at 23:40 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
samuel.mortensonWe should consider moving to PrivateTempStore in this issue as well, with a SharedTempStore lock.
Comment #3
samuel.mortensonSo I started work on this and realized that unlike \Drupal\views_ui\ViewsUI, we do not have an abstracted object that represents temporary state in Panels. Before I write more code - where do other maintainers think that this should live? I was planning on giving PanelsStorageInterface/PanelsStorageBase common methods for dealing with TempStore and locks, so that all UIs can use the same methods to load/clear/lock a PanelsDisplay (using what Panels IPE is already doing as a base).
Thoughts?
Comment #4
dsnopekI'd need to see the code in question to really say if it'd be appropriate to add to PanelsStorageInterface. If it's not something that we'll customize for individual Panels storage plugins, then I think it probably isn't appropriate there.
If it's something that will work the same always, maybe a better place would be on PanelsStorageManager/PanelsStorageManagerInterface?
Comment #5
tim.plunkettThis prevents the tempstore from bleeding over to other users when they *view* the panelized entity.
This does not yet address two users concurrently editing.
Comment #8
tim.plunkettUh, works on my machine...
Comment #11
japerryComment #12
tim.plunkettMade commits against CTools, Panels, and Panelizer to add a locking mechanism similar to Views UI.
If more work is needed, please open new issues and link them from here!