Problem/Motivation

At the moment the CDN version and make file are using different versions of the leaflet library. I think, we should make sure to unify that for further releases.

Proposed resolution

  • Use always the same recommended library version
  • In addition, because we touch it anyhow, update both to the current 0.7.7. library stable version
CommentFileSizeAuthor
#2 leaflet-unify_library_versions-2699011-2.patch1.23 KBszeidler

Comments

szeidler created an issue. See original summary.

szeidler’s picture

szeidler commented
Status: Active » Needs review
StatusFileSize
new leaflet-unify_library_versions-2699011-2.patch1.23 KB

Here's a patch.

  • pvhee committed b2365bf on 8.x-1.x authored by szeidler 
    Issue #2699011 by szeidler: Unify library versions in CDN version and...
pvhee’s picture

pvhee commented
Status: Needs review » Fixed

Make a lot of sense and thanks for the patch szeidler!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

NetNerdy’s picture

NetNerdy commented
Priority: Normal » Major
Status: Closed (fixed) » Active

this patch shouldn't be marking as "Closed (fixed)" before this patch isn't taking in code!

(see this newly post with the same issue https://www.drupal.org/node/2732323 )

steven jones’s picture

steven jones commented
Status: Active » Closed (fixed)

Fairly certain this patch is in code:

http://cgit.drupalcode.org/leaflet/commit/?id=b2365bf

So this really is fixed (and closed)