Update to CKEditor 4.5.8. http://ckeditor.com/blog/CKEditor-4.5.8-Released

4.5.8 brings minor bugfixes.

See also:

CommentFileSizeAuthor
#9 2698587-for-81x-9.patch44.5 KBthpoul
#3 2698587-3.patch44.5 KBthpoul

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes
thpoul’s picture

thpoul commented
Status: Active » Needs review
StatusFileSize
new 2698587-3.patch44.5 KB
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Version: 8.2.x-dev » 8.1.x-dev
Status: Needs review » Reviewed & tested by the community
Issue tags: +rc target triage

Basic manual testing didn't uncover any problems.

Considering the very short and simple changelog (http://ckeditor.com/release/CKEditor-4.5.8) and the fact that CKEditor has comprehensive test coverage, I think this is ready.

8.1 is in RC, but perhaps it's still worth getting this in 8.1, because this is the CKEditor version we'll stick to for the entire 8.1 cycle (barring security releases). Leaving that decision to the core committers. Tagging accordingly.

  • catch committed 1516faf on 8.2.x 
    Issue #2698587 by thpoul: Update CKEditor library to 4.5.8
catch’s picture

catch
he/him
Primary language English
commented
Issue tags: -rc target triage +rc target

Committed 1516faf and pushed to 8.2.x. Thanks!

Leaving RTBC for 8.1.x and tagging rc target. I think we should do it, but will wait for a +1 from someone else.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2698587-3.patch, failed testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +Needs reroll
thpoul’s picture

thpoul commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 2698587-for-81x-9.patch44.5 KB
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Wow, that was fast! Back to 8.1 RTBC, see #6.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

It makes sense to have libraries updated for minor releases. Committed 6592dc6 and pushed to 8.1.x. Thanks!

  • alexpott committed 6592dc6 on 8.1.x 
    Issue #2698587 by thpoul: Update CKEditor library to 4.5.8

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.