Update to CKEditor 4.5.7. http://ckeditor.com/blog/CKEditor-4.5.7-Released

4.5.6 & 4.5.7 bring minor bugfixes. Also, 4.5.7 brings a new translation for the first time: Swiss German, de-ch.

The addition of a language requires extra attention (see #2050097: Map CKEditor languages to Drupal languages).

Wiktor Walc (from the CKEditor team) contacted me about this
I replied:

Apparently we also have Swiss German, but using a very different langcode:

'gsw-berne' => array('Swiss German', 'Schwyzerdütsch'),

We had a similar thing (in the issue you linked, even) with for example Norwegian being "nb" in Drupal and "no" in CKEditor (and pt-pt/pt, zh-hans/zh). We updated language.mappings.yml to account for that.

So, AFAICT we will only need to update language.mappings.yml at the same time as updating to CKE 4.5.7 (or prior to).

Adding Gábor (language system maintainer) and Sascha (Swiss German speaker and big contributor to the language system) to get their thoughts.

@Berdir replied:

Hey

Funny.

Those two languages are actually something quite different, so that's fine.

de-ch is swiss "high german", we don't use some characters like ß and
we also sometimes use different words and so on. But it's still
"normal" german.

gsw-berne on the other hand is one of the many swiss dialects. (It's
my dialect, so it's obviously the best one ;)). As far as I know, it
only exists in Drupal because there was a website about that dialect
that used Drupal, so they somehow managed to make it an official
default language. Nobody really uses that. We only write dialect in
short messages, facebook and so on (and didn't before those existed),
not for any sort of official communication.

Conclusion of the history lesson, there's no need to map those
language codes together.

Sascha

See also:

CommentFileSizeAuthor
#11 2663566-11.patch2.04 MBthpoul
#4 2663566-4.patch3.04 MBthpoul

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#2050097: Map CKEditor languages to Drupal languages
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Category: Bug report » Task
thpoul’s picture

thpoul commented
Status: Active » Needs review
Issue tags: +Needs manual testing
StatusFileSize
new 2663566-4.patch3.04 MB

Needs manual testing. Tagging accordingly.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Version: 8.0.x-dev » 8.1.x-dev

Thanks for rolling this patch! Will do the manual testing next, unless someone beats me to it :)

Friday, February 5th, 2016
17:58:55 <WimLeers> first CKE update: https://www.drupal.org/node/2663566
17:58:59 <WimLeers> 8.0 or 8.1?
17:59:10 <WimLeers> (it's not a security fix, just a bug fix)

Monday, February 8th, 2016
01:23:04 <catch> For me, unless the bug directly affects us, 8.1
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Update CKEditor library to 4.5.7 » [PP-1] Update CKEditor library to 4.5.7
Status: Needs review » Postponed

I just realized this probably should wait until after #1993928: Language of parts: Introduce a language toolbar button lands, since that's been RTBC for one month now: #1993928-167: Language of parts: Introduce a language toolbar button.

This patch is much easier to reroll than that one.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Postponed » Needs work
Issue tags: +Needs reroll

#1993928: Language of parts: Introduce a language toolbar button landed. Let's reroll this.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: [PP-1] Update CKEditor library to 4.5.7 » Update CKEditor library to 4.5.7
thpoul’s picture

thpoul commented
Assigned: Unassigned » thpoul

On it

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Awesome, thanks!

(Note this is not urgent, and is not bound by the 8.1 deadline.)

thpoul’s picture

thpoul commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 2663566-11.patch2.04 MB

Manual testing is next! :) (the size diff between 4 and 11 is me being silly by not using the build.sh on 4)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs manual testing

Patch looks great, manual testing finds no problems.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.2.x and cherry-picked to 8.1.x. Thanks!

  • catch committed 134c533 on 8.2.x 
    Issue #2663566 by thpoul: Update CKEditor library to 4.5.7

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.