Problem/Motivation

Now idlist command no support multiple souceids e.g I have three sourceids:

    - id_profile
    - year
    - trim

If I need migrate one row with idprofile=3, year=2014,trim=3 sources I can not.

Proposed resolution

Updated the command to do:
drush mi migration_test --idlist="sourceid1,sourceid2,sourceid3"

e.g for multiple
drush mi migration_test --idlist="3:2014:3,2:2011:2"
e.g for single sourceid
drush mi migration_test --idlist="2"

Remaining tasks

Write a patch.

CommentFileSizeAuthor
#9 make_idlist_command-2698067-9.patch1.42 KBedysmp
#5 idlist-support-multiple-sourceids-2698067-5.patch1.38 KBedysmp
#5 interdiff-2-5.txt986 bytesedysmp
#2 idlist-support-multiple-sourceids-2698067-2.patch1.72 KBedysmp

Comments

edysmp created an issue. See original summary.

edysmp’s picture

edysmp
Primary language Spanish
Location Nicaragua
commented
Status: Active » Needs review
StatusFileSize
new idlist-support-multiple-sourceids-2698067-2.patch1.72 KB
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Related issues: +#2047815: The --idlist parameter should support multiple source keys.

See the D7 version of this functionality: #2047815: The --idlist parameter should support multiple source keys.

edysmp’s picture

edysmp
Primary language Spanish
Location Nicaragua
commented
Assigned: Unassigned » edysmp
edysmp’s picture

edysmp
Primary language Spanish
Location Nicaragua
commented
Assigned: edysmp » Unassigned
StatusFileSize
new interdiff-2-5.txt986 bytes
new idlist-support-multiple-sourceids-2698067-5.patch1.38 KB
edysmp’s picture

edysmp
Primary language Spanish
Location Nicaragua
commented
Issue summary: View changes
edysmp’s picture

edysmp
Primary language Spanish
Location Nicaragua
commented
Issue summary: View changes
quietone’s picture

quietone commented

I tested this with d7_block, which has 3 source ids. It worked for importing a single block but failed for a multiple.

$ drush mi upgrade_d7_block --idlist="system:main:bartik,system:main:seven"    
Processed 0 items (0 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d7_block' 
$ drush mi upgrade_d7_block --idlist="system:main:seven"
Processed 1 item (1 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d7_block' 
$ drush mi upgrade_d7_block --idlist="system:main:bartik"
Processed 1 item (1 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d7_block'

Should this feature also be available for rollback?

edysmp’s picture

edysmp
Primary language Spanish
Location Nicaragua
commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
StatusFileSize
new make_idlist_command-2698067-9.patch1.42 KB

Thanks @quitone for review, here a new path :), So for rollback seem right, a subscriber to MigrateEvents::PRE_ROW_DELETE?

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented

idlist is not currently supported for rollback at all - that should be a separate issue.

  • mikeryan committed e40849e on 8.x-2.x authored by edysmp 
    Issue #2698067 by edysmp: Make idlist command support multiple sourceids
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

badrange’s picture

badrange commented

This fix created a bug for us who are fetching data from a source a colon in the IDs. I created a patch here:
https://www.drupal.org/project/migrate_tools/issues/2915099