Comments

dasjo created an issue. See original summary.

dasjo’s picture

Assigned: Unassigned » dasjo
una_maria’s picture

dasjo’s picture

Assigned: dasjo » Unassigned
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: facets-active-items-class-2696979-3-8.patch, failed testing.

The last submitted patch, 3: facets-active-items-class-2696979-3-8.patch, failed testing.

borisson_’s picture

This should resolve those test failures.

Status: Needs review » Needs work

The last submitted patch, 7: active_items_should-2696979-7.patch, failed testing.

The last submitted patch, 7: active_items_should-2696979-7.patch, failed testing.

borisson_’s picture

Status: Needs review » Needs work

The last submitted patch, 10: active_items_should-2696979-10.patch, failed testing.

The last submitted patch, 10: active_items_should-2696979-10.patch, failed testing.

borisson_’s picture

StryKaizer’s picture

  1. +++ b/src/Plugin/facets/widget/LinksWidget.php
    @@ -72,38 +72,33 @@ class LinksWidget implements WidgetInterface {
    +    $classes = ['facet_item'];
    

    facet-item instead of facet_item

  2. +++ b/src/Plugin/facets/widget/LinksWidget.php
    @@ -72,38 +72,33 @@ class LinksWidget implements WidgetInterface {
    +      $classes[] = 'facet_item--active';
    

    Can we use 'is-active' on the link itself, and 'facet-item--active-trail' on the wrapper to be on par with core menu items?

Haven't tested nested facets yet for this change, but I'd suggest to follow the same principle there as core menu with nested items does.

StryKaizer’s picture

Status: Needs review » Needs work
borisson_’s picture

borisson_’s picture

Status: Needs work » Needs review

Go testbot, go.

StryKaizer’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me

  • borisson_ committed 3bcbc1d on 8.x-1.x
    Issue #2696979 by borisson_, una_maria, dasjo: Active items should have...
borisson_’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.