CommentFileSizeAuthor
#16 active_items_should-2696979-16.patch8.4 KBborisson_
#16 interdiff.txt5.47 KBborisson_
#13 active_items_should-2696979-13.patch7.12 KBborisson_
#13 interdiff.txt1.64 KBborisson_
#10 active_items_should-2696979-10.patch7.25 KBborisson_
#7 active_items_should-2696979-7.patch4.53 KBborisson_
#7 interdiff.txt3.05 KBborisson_
#3 facets-active-items-class-2696979-3-8.patch2.01 KBuna_maria

Comments

dasjo created an issue. See original summary.

dasjo’s picture

dasjo
he/him
Primary language German
Location Zurich
commented
Assigned: Unassigned » dasjo
una_maria’s picture

una_maria commented
StatusFileSize
new facets-active-items-class-2696979-3-8.patch2.01 KB

Adds a class for active items, by @dasjo.

dasjo’s picture

dasjo
he/him
Primary language German
Location Zurich
commented
Assigned: dasjo » Unassigned
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: facets-active-items-class-2696979-3-8.patch, failed testing.

The last submitted patch, 3: facets-active-items-class-2696979-3-8.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt3.05 KB
new active_items_should-2696979-7.patch4.53 KB

This should resolve those test failures.

Status: Needs review » Needs work

The last submitted patch, 7: active_items_should-2696979-7.patch, failed testing.

The last submitted patch, 7: active_items_should-2696979-7.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new active_items_should-2696979-10.patch7.25 KB

No interdiff, a new approach.

Status: Needs review » Needs work

The last submitted patch, 10: active_items_should-2696979-10.patch, failed testing.

The last submitted patch, 10: active_items_should-2696979-10.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.64 KB
new active_items_should-2696979-13.patch7.12 KB

Let's try this again.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented 
  1. +++ b/src/Plugin/facets/widget/LinksWidget.php
@@ -72,38 +72,33 @@ class LinksWidget implements WidgetInterface {
+    $classes = ['facet_item'];

    facet-item instead of facet_item 

  2. +++ b/src/Plugin/facets/widget/LinksWidget.php
@@ -72,38 +72,33 @@ class LinksWidget implements WidgetInterface {
+      $classes[] = 'facet_item--active';

    Can we use 'is-active' on the link itself, and 'facet-item--active-trail' on the wrapper to be on par with core menu items?

Haven't tested nested facets yet for this change, but I'd suggest to follow the same principle there as core menu with nested items does.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Needs review » Needs work
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
StatusFileSize
new interdiff.txt5.47 KB
new active_items_should-2696979-16.patch8.4 KB

This resolves the problems from #14.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Needs review

Go testbot, go.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me

  • borisson_ committed 3bcbc1d on 8.x-1.x 
    Issue #2696979 by borisson_, una_maria, dasjo: Active items should have...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented

What happened to this? Did it get overwritten by a different issue?