XHProf entries are not links in D8

Increasing the priority to Major as this functionality is critical to this module. Please change it back if you think otherwise.

This would be a very useful feature.

Our work around for now is to use the code supplied with the PECL extension.

1. In php.ini (or xhprof.ini ) specify a non-tmp directory as xhprof.output_dir, restart httpd
2. From the PECL package, copy the contents of "xhprof_html" (e.g. /usr/share/pear/xhprof_html ) to a local web directory
3. Edit the file index.php from step 2 and set $GLOBALS['XHPROF_LIB_ROOT'] to the directory in step 1
4. Do some profiling in Drupal to grab traces
5. In your web browser, visit the the directory set up in step 3. E.g. http://localhost/xhprof

It needs to implement \Drupal\xhprof\Controller\XHProfController::symbolAction()

Here is a patch with symbolAction() implementation.

I didn't find out how to have the "Exclusive Metrics for Current Function" and there is no link "View Top Level Run Report" as we had on D7 version.

But the main behavior seems ok.

Having a look now, the patch seems to work well. Thanks.

I tested the patch against the current version and it works fine. With this patch the module is so much better. Thank you!

It looks great! just minor nitpicks like missing phpdocs and different array formatting

PS: somehow it needs to setup testing of the module classes in separate issue

+++ b/src/Controller/XHProfController.php
@@ -161,8 +161,34 @@ class XHProfController extends ControllerBase {
+    $sort = $request->get('sort', 'wt');

it should be request->query->get()

I made a new version of the patch addressing the request->query->get(). I also changed the array syntax.
I did not feel that I know enought about the module to add meaningful phpdocs...

Changed to needs review.

Sorry, I'm not really maintaining this module but I needed it today so trying to pitch in. This patch works and is sorely needed so in it goes.