Problem/Motivation

Right now all the columns of the diff table have the same size and looks like this:

Proposed resolution

We should reduce the size of the type on change column, this will make the diff more readable and good looking.
Here is how it should look like:

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#12 Screen Shot 2018-05-03 at 14.53.31.png56.15 KBlauriii
#10 Screen Shot 2018-04-23 at 4.51.17 PM.png142.9 KBruneasgar
#9 9-2695945-reduce-size.patch756 bytesecrown
#2 reduce_the_size_of_the-2695945-2.patch756 bytesedurenye
diff_example_with_fix.png116.37 KBedurenye
diff_example_without_fix.png113.88 KBedurenye

Comments

edurenye created an issue. See original summary.

edurenye’s picture

edurenye commented
Status: Active » Needs review
StatusFileSize
new reduce_the_size_of_the-2695945-2.patch756 bytes

Fixed, here it looks like the last screenshot.

edurenye’s picture

edurenye commented

To reproduce that do the following:

  1. Use drush cex to sync the config.
  2. Modify any config for example a view.
  3. Go to configuration > Development > Configuration synchronization and you will see the View differences button.
  4. Click the View differences button and you will see the diff table.
edurenye’s picture

edurenye commented
Version: 8.1.x-dev » 8.2.x-dev

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

ecrown’s picture

ecrown commented
StatusFileSize
new 9-2695945-reduce-size.patch756 bytes

re-rolling patch for drupal 8.6.x

runeasgar’s picture

runeasgar commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2018-04-23 at 4.51.17 PM.png142.9 KB
  1. Reproducing. drush cex. Editing a view. Looking at config diff. Indeed, it is pretty crummy.
  2. Applying patch: curl -l https://www.drupal.org/files/issues/2018-04-13/9-2695945-reduce-size.patch | git apply -v.
  3. Applied clean.
  4. drush cr
  5. Look at config diff again: looks fantastic. Screenshot attached.

Marking as RTBC.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: +Needs frontend framework manager review
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Assigned: edurenye » Unassigned
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs frontend framework manager review
StatusFileSize
new Screen Shot 2018-05-03 at 14.53.31.png56.15 KB

Seems like that makes the situation less awkward. This does slightly change the way the table is behaving since before the columns used to be equal size, but after the change that is not ensured.

For example:

However, I think this is already a nice improvement with little effort compared to what it would take to make rest of the changes. If any of you are interested in working on improvements for the CMI UI, this could be a nice follow-up to work on.

Committed 233ae5c and pushed to 8.6.x. Thanks! ✨

  • lauriii committed 233ae5c on 8.6.x 
    Issue #2695945 by edurenye, ecrown, runeasgar: Reduce the size of the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.