Add bulk operations support for views

That's a use case I encountered today, so I definitely agree. That's not so trivial, but I believe the best approach to this would be to add a "SELECT" column to the tables containing the forms / messages with a checkbox for each entity and a "Delete selected" button as well as a "Select all" button. A "Display per page" dropdown menu to select how many elements to display per page with an "All" option would also be needed.

The bulk operations support is generic in views.

To get it for an entity type, all you need is to have actions (action plugin + action config entity). See how node.module defines the delete action plugin and the config entity for it. Define those, re-install the module and you should be able to add that to the view.

give it a shot.
Questions :

1. will we make contact_form entity translatable ? any existing issue for it ? The translations has been taken care in DeleteMultiple message form as I have borrowed the code from DeleteMultiple node action form ?
2. What other actions do we need ?

Pending items :

1. Do we need the hook_post_update_NAME for views changes ?
2. Need tests.

The code is workable and it can be tested.

let' s give the candy to testbot :)

N/W for #5

Re #5 Questions:

1. Let's keep this simple now. Message is not translatable so let's not make delete action translatable.
2. I don't think there is any other action we can add at this point.

Re #5 Pending Items:

1. We need an update hook to enable the action and then update the currently installed view to use this action.
2. Always.

I think we should not add this action to current view to avoid upgrade path hassle for view. Just add the default action and enable it in update hook so that it'll be available as views field.

#9
1. Addressed, remove the translatable code from message deletion form.
2. Okay Thanks!

#5 Pending Items are still left. Leaving this open for others to pickup to work the pending stuff.I'll probably get back on this on tuesday.

Looking great, just some minor observations.
Only thing missing is some tests.

1. +++ b/contact_storage.routing.yml
   @@ -0,0 +1,6 @@
   +    _permission: 'administer contact forms'
   

   We need to add this to our follow-up (in the queue around adding more permissions). Because deleting shouldn't need the uber-permission.

2. +++ b/src/Form/DeleteMultiple.php
   @@ -0,0 +1,125 @@
   +      $this->privateTempStoreFactory->get('message_multiple_delete_confirm')->delete(\Drupal::currentUser()->id());
   

   We can inject the current user service too

3. +++ b/src/Form/DeleteMultiple.php
   @@ -0,0 +1,125 @@
   +      drupal_set_message(\Drupal::translation()->formatPlural($count, 'Deleted 1 message.', 'Deleted @count messages.'));
   

   Nit: we could put this in a protected method to isolate it for when it gets deprecated.

Addressed #12.2, #12.3
#12.1, For permissions I'm working on a sandbox project here https://www.drupal.org/sandbox/naveenvalecha/2725179 I'll take care in the patch.

Addressed #5.2 Added tests
#5.1 can you elaborate little bit more.Do you mean to add/create the action config entity in hook_update ?

Nice work @naveenvalecha.

1. +++ b/contact_storage.post_update.php
   @@ -0,0 +1,23 @@
   +/**
   + * Enable the contact form delete multiple action
   + */
   +function contact_storage_post_update_enable_action() {
   +
   +}
   

   Let's make this an update hook and add the action to active config.
   Something like this

   @@ -125,5 +127,34 @@ function contact_storage_update_N() {
     $entity_type_manager = \Drupal::entityTypeManager();
   
     // Save the bulk delete action to config.
     $config_install_path = $module_handler->getModule('contact_storage')->getPath() . '/' . InstallStorage::CONFIG_INSTALL_DIRECTORY;
     $storage = new FileStorage($config_install_path);
     $entity_type_manager
       ->getStorage('action')
       ->create($storage->read('system.action.message_delete_action'))
       ->save();
   

2. --- /dev/null
   +++ b/config/install/system.action.message_delete_action.yml
   

   Should it be named system.action or contact_storage.action?

3. +++ b/src/Form/DeleteMultiple.php
   @@ -0,0 +1,140 @@
   +      return new RedirectResponse($this->getCancelUrl()->setAbsolute()->toString());
   

   I think this can be just Url object no need to convert it to string.

4. +++ b/src/Form/DeleteMultiple.php
   @@ -0,0 +1,140 @@
   +      $this->logger('content')->notice('Deleted @count messages.', ['@count' => $count]);
   

   I think content logger is not correct logging service here.

5. +++ b/src/Plugin/views/field/MessageBulkForm.php
   @@ -0,0 +1,21 @@
   +    return $this->t('No message selected.');
   

   Can we add a quick assert about this as well in the test?

#17.1
Added Thanks!
#17.2
It would be the system.action
#17.3
it should be string see https://github.com/symfony/http-foundation/blob/master/RedirectResponse....
#17.4
Used the contact logger.
#17.5
Added

This is ready imo. Thanks @naveenvalecha for addressing the feedback.

Just minor nits, could be fixed on commit

1. +++ b/src/Form/DeleteMultiple.php
   @@ -0,0 +1,140 @@
   +    return $this->formatPlural(count($this->messages), 'Are you sure you want to delete this item?', 'Are you sure you want to delete these items?');
   ...
   +      drupal_set_message($this->stringTranslation->formatPlural($count, 'Deleted 1 message.', 'Deleted @count messages.'));
   

   inconsistency

2. +++ b/src/Form/DeleteMultiple.php
   @@ -0,0 +1,140 @@
   +    $form = parent::buildForm($form, $form_state);
   +
   +    return $form;
   

   could be oneliner

Fixed nits mentioned in #20
Also fixed some of the docs.

Now looks great for me! Thanx a lot @naveenvalecha

+++ b/contact_storage.install
@@ -43,3 +46,19 @@ function _contact_storage_ensure_fields() {
+    ->create($storage->read('system.action.message_delete_action'))

We need an uninstall hook to remove this from active storage as well.

No need for uninstall hook, just add an enforced config dependency on this module so it gets removed automatically.

http://drupal.stackexchange.com/questions/195173/delete-a-content-type-p... (works for all config entities)

just add an enforced config dependency on this module so it gets removed automatically.

nice!, Enforced config dependency in system.action.message_delete_action

+++ b/config/install/system.action.message_delete_action.yml
@@ -2,7 +2,7 @@ langcode: en
+    - contact_storage

In my experience this doesn't work all the time. Can we add a test to verify that it really works?

+++ b/config/install/system.action.message_delete_action.yml
@@ -2,7 +2,7 @@ langcode: en
   module:
-    - contact
+    - contact_storage
 id: message_delete_action
 label: 'Delete message'

this is not an enforced dependency, it is a normal dependency. See the example I linked. You don't want to touch what is added automatically but add yours in enforced.

reverted previous change in #27.
Addressed #29

#28,
I have seen at couple of places in core about the enforced config removal.

1. +++ b/config/install/system.action.message_delete_action.yml
   @@ -0,0 +1,13 @@
   +  module:
   +    - contact
   
   +++ b/src/Plugin/Action/DeleteMessage.php
   @@ -0,0 +1,93 @@
   + *   id = "message_delete_action",
   

   action defined in contact_storage module so why it depends on contact?
   The enforced here is only for reason to uninstall this config when module uninstalled

2. +++ b/src/Tests/BulkFormTest.php
   @@ -0,0 +1,78 @@
   +    'contact',
   ...
   +    'contact_storage',
   +    'views',
   

   contact_storage already depends on contact and views so I suppose they are not needed

#31.1 Moved the action dependency to contact_storage.
#31.2 yup, agree accommodated the changes accordingly.

ignore previous patch.

Now looks ready

Fixed, thanks - rerolled on commit

How to delete multiple form submissions? VBO isn't available on D8 and I can't spot on documentation. Ah.. it's a view.

To this guy: /admin/structure/views/view/contact_messages
add field:
Contact message: Message operations bulk form (Message operations bulk form)
And save. Works. Becomes available as checkbox and a delete dropdown just as needed. Should probably get on the readme.