Problem/Motivation

User interface text should not use contractions like e.g., 'You've, Can't, Shouldn't. Use the complete phrase instead such as 'You have, Cannot, Should not'

https://www.drupal.org/node/604342

Proposed resolution

Replace the occurrence of 'You've, Can't, Shouldn't. Use the complete phrase instead such as 'You have, Cannot, Should not'

Remaining tasks

User interface changes

API changes

Data model changes

Original report by Devaraj johnson B

(Text of the original report, for legacy issues whose initial post was not the issue summary. Use rarely.)

Comments

Devaraj johnson created an issue. See original summary.

devaraj johnson’s picture

StatusFileSize
new8.83 KB

Updating the patch

devaraj johnson’s picture

Status: Active » Needs review
devaraj johnson’s picture

Issue summary: View changes
chi’s picture

What about haven't, isn't, aren't?

devaraj johnson’s picture

StatusFileSize
new167.09 KB

Yes that too will come under contractions. Updated the patch

Status: Needs review » Needs work

The last submitted patch, 6: do-not-use-contractions-6.patch, failed testing.

The last submitted patch, 6: do-not-use-contractions-6.patch, failed testing.

The last submitted patch, 6: do-not-use-contractions-6.patch, failed testing.

chi’s picture

This won't be simple. grep -rn "[a-z]'t" core | wc -l returns 1836. I would split the task into a few small ones.

devaraj johnson’s picture

yes that will work

rteijeiro’s picture

You shouldn't change any vendor file, just the Drupal core files.

chi’s picture

therealssj’s picture

StatusFileSize
new1.12 MB

Ran a little script.
Did not touch js and css files.
Now grep -rn "[a-z]'t" core | wc -l returns 300.

therealssj’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 14: 2690557-14.patch, failed testing.

therealssj’s picture

StatusFileSize
new1.12 MB

Another try.
Tested the patch.

therealssj’s picture

Status: Needs work » Needs review
leolandotan’s picture

Sorry but based on the link(https://www.drupal.org/node/604342) provided in the issue description it says, "This page contains guidelines for Drupal module and theme developers to use when writing user interfaces text (e.g., buttons, labels, in-page help, descriptions below fields, and (error) messages." but in these fixes were changing code comments that aren't related to user interfaces text.

Just wanted to understand and maybe make the scope clearer.

Thanks!

Status: Needs review » Needs work

The last submitted patch, 17: 2690557-17.patch, failed testing.

himanshugautam’s picture

I completely agree with leolando.tan. I actually had this thing in mind when tried to work on this bug. These changes, as made in patches, are mostly in comments and have nothing in relation with user interface text.

Thanks!

magi.yv’s picture

I have replaced contractions with complete phrases on user interface texts. As per #21 and #19 skipped comment and readme texts.

magi.yv’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 22: drupal-remove_contradictions-2690557-22.patch, failed testing.

magi.yv’s picture

Status: Needs work » Needs review
magi.yv’s picture

The test failure is unrelated to my work. Can any one look into this ?

anish.a’s picture

Status: Needs review » Needs work

Seems like your changes needs to be rerolled to the latest 8.2.x-dev branch. Lot of files changed.

magi.yv’s picture

Status: Needs work » Needs review
StatusFileSize
new66.61 KB

Patch rerolled to latest changes.

Status: Needs review » Needs work

The last submitted patch, 28: drupal-remove_contradictions-2690557-28.patch, failed testing.

magi.yv’s picture

Status: Needs work » Needs review
StatusFileSize
new64.78 KB

Status: Needs review » Needs work

The last submitted patch, 30: drupal-remove_contradictions-2690557-29.patch, failed testing.

magi.yv’s picture

Assigned: devaraj johnson » magi.yv
himanshugautam’s picture

tested the patch and its working.
Good work @magi.yv

anish.a’s picture

It fails the automated test.

The last submitted patch, 30: drupal-remove_contradictions-2690557-29.patch, failed testing.

tstoeckler’s picture

Issue tags: +DrupalBCDays
tstoeckler’s picture

@magi.yv: Oops missed that this was assigned before tagging it for the sprint on the weekend, sorry. Are you still working on this?

anish.a’s picture

Assigned: magi.yv » Unassigned

No. You can take this.

tstoeckler’s picture

Thanks for the feedback!

lokapujya’s picture

What's wrong with contractions?

chi’s picture

@lokapujya, there are some good explanations in that issue.

lokapujya’s picture

It reads:

Anything else is more of an end user facing manual/directions, these should be informal, inline with current Drupal.org guidelines.

We really shouldn't be converting contractions that are in the UI. The UI should be informal. By not using contractions, Drupal is going to sound snobbery.

jmikii’s picture

Assigned: Unassigned » jmikii
Issue summary: View changes
Status: Needs work » Active
Issue tags: +DCTransylvania
jonathanshaw’s picture

Space is often at a premium in UI text; perhaps there is an advantage to contractions sometimes.

jmikii’s picture

Assigned: jmikii » Unassigned
stpaultim’s picture

Status: Active » Closed (won't fix)

Spoke with a few folks (including heddn) at DrupalCon New Orleans and we reached a consensus that this creates serious issues with translations. Closing this issue.

rosinegrean’s picture

Issue tags: -DCTransylvania