Closed (won't fix)
Project:
Drupal core
Version:
8.2.x-dev
Component:
user interface text
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
19 Mar 2016 at 10:18 UTC
Updated:
24 Mar 2017 at 09:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
devaraj johnson commentedUpdating the patch
Comment #3
devaraj johnson commentedComment #4
devaraj johnson commentedComment #5
chi commentedWhat about haven't, isn't, aren't?
Comment #6
devaraj johnson commentedYes that too will come under contractions. Updated the patch
Comment #10
chi commentedThis won't be simple.
grep -rn "[a-z]'t" core | wc -lreturns 1836. I would split the task into a few small ones.Comment #11
devaraj johnson commentedyes that will work
Comment #12
rteijeiro commentedYou shouldn't change any vendor file, just the Drupal core files.
Comment #13
chi commentedBtw, vendor directory was removed recently from the repository.
#1475510: Remove external dependencies from the core repo and let Composer manage the dependencies instead
Comment #14
therealssj commentedRan a little script.
Did not touch js and css files.
Now
grep -rn "[a-z]'t" core | wc -lreturns 300.Comment #15
therealssj commentedComment #17
therealssj commentedAnother try.
Tested the patch.
Comment #18
therealssj commentedComment #19
leolandotan commentedSorry but based on the link(https://www.drupal.org/node/604342) provided in the issue description it says, "This page contains guidelines for Drupal module and theme developers to use when writing user interfaces text (e.g., buttons, labels, in-page help, descriptions below fields, and (error) messages." but in these fixes were changing code comments that aren't related to user interfaces text.
Just wanted to understand and maybe make the scope clearer.
Thanks!
Comment #21
himanshugautam commentedI completely agree with leolando.tan. I actually had this thing in mind when tried to work on this bug. These changes, as made in patches, are mostly in comments and have nothing in relation with user interface text.
Thanks!
Comment #22
magi.yv commentedI have replaced contractions with complete phrases on user interface texts. As per #21 and #19 skipped comment and readme texts.
Comment #23
magi.yv commentedComment #25
magi.yv commentedComment #26
magi.yv commentedThe test failure is unrelated to my work. Can any one look into this ?
Comment #27
anish.a commentedSeems like your changes needs to be rerolled to the latest 8.2.x-dev branch. Lot of files changed.
Comment #28
magi.yv commentedPatch rerolled to latest changes.
Comment #30
magi.yv commentedComment #32
magi.yv commentedComment #33
himanshugautam commentedtested the patch and its working.
Good work @magi.yv
Comment #34
anish.a commentedIt fails the automated test.
Comment #36
tstoecklerComment #37
tstoeckler@magi.yv: Oops missed that this was assigned before tagging it for the sprint on the weekend, sorry. Are you still working on this?
Comment #38
anish.a commentedNo. You can take this.
Comment #39
tstoecklerThanks for the feedback!
Comment #40
lokapujyaWhat's wrong with contractions?
Comment #41
chi commented@lokapujya, there are some good explanations in that issue.
Comment #42
lokapujyaIt reads:
We really shouldn't be converting contractions that are in the UI. The UI should be informal. By not using contractions, Drupal is going to sound snobbery.
Comment #43
jmikii commentedComment #44
jonathanshawSpace is often at a premium in UI text; perhaps there is an advantage to contractions sometimes.
Comment #45
jmikii commentedComment #46
stpaultim commentedSpoke with a few folks (including heddn) at DrupalCon New Orleans and we reached a consensus that this creates serious issues with translations. Closing this issue.
Comment #47
rosinegrean commented