When all articles are enabled by default, we should also be able to exclude an article. It seems that even if I uncheck it and save the node, it still shows that it's included and doesn't remove the article from the feed.

CommentFileSizeAuthor
#5 fb_instant_articles-ability_to_exclude_when_all_included_by_default-2688241-5.patch1.79 KBrromore
#3 ability_to_exclude_when_all_included_by_default-2688241.patch2.55 KBrromore

Comments

vgardner created an issue. See original summary.

vgardner’s picture

vgardner
Location London
commented
Title: Abilitiy to exclude articles when all articles are included by default » Ability to exclude articles when all articles are included by default
rromore’s picture

rromore commented
StatusFileSize
new ability_to_exclude_when_all_included_by_default-2688241.patch2.55 KB

Woops! Looks like I had a bug in my original patch from https://www.drupal.org/node/2685139 that caused this. This patch:

  • fixes that bug
  • fixes some minor documentation details from the last patch
  • reduces the length of a conditional in `fb_instant_articles_node_form_submit` by utilizing the xor operator.
vgardner’s picture

vgardner
Location London
commented
Status: Active » Needs work

Seems that now the inverse is now working (all disabled by default, include per article basis). Single articles are not included.
I suspect it's because we should be checking for fb_instant_articles_is_article_type instead of fb_instant_articles_is_article in the node submit.
$fb_instant_enabled = fb_instant_articles_is_article('node', $form['type']['#value']);

rromore’s picture

rromore commented
StatusFileSize
new fb_instant_articles-ability_to_exclude_when_all_included_by_default-2688241-5.patch1.79 KB

I think you're right. I've created a new patch to make that change, which was also rolled against the newest version.

  • vgardner committed 17770eb on 7.x-1.x authored by rromore 
    Issue #2688241 by rromore: Ability to exclude articles when all articles...
vgardner’s picture

vgardner
Location London
commented
Status: Needs work » Fixed

Works as expected. Cheers @rromore!

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Fixed » Closed (fixed)

Running through and closing issues that are marked Fixed.