For our use case for this module, we need the ability to enable/disable Facebook Instant Article functionality on a per-node basis.

CommentFileSizeAuthor
#6 configure_fbia_per_node-2685139_2.patch10.9 KBvgardner
#2 configure_fbia_per_node-2685139.patch11.32 KBrromore

Comments

rromore created an issue. See original summary.

rromore’s picture

rromore commented
StatusFileSize
new configure_fbia_per_node-2685139.patch11.32 KB

This patch also fixes a notice thrown from facebook_instant_articles_preprocess_node() if no regions are set, and adds a configurable variable for the number of items to include in the feed.

vgardner’s picture

vgardner
Location London
commented
Version: » 7.x-1.x-dev

Hi @rromore, I really like this change and I think it adds a lot of value to the module. Thanks!

A couple of things:
- We should probably use a different form/fieldset for node edit form than the node type edit form, as we in the future there'll probably different fields for both. Plus the label is confusing if you're on the node edit for as it says "Configure content type for Facebook Instant Article mappings." and then "Include Content Type in Facebook Instant Articles feed.". Should be "Include this node/entity in the Facebook Instant Articles feed".

- When all articles are enabled by default, we should also be able to exclude an article. It seems that even if I uncheck it and save the node, it still shows that it's included and doesn't remove the article from the feed.

- I'm changing the namespace of the module to fb_instant_articles, thus the files and function names will change. So please alter the patch accordingly. That will be my latest commit on branch 7.x-1.x.

  • vgardner committed f641453 on 7.x-1.x authored by rromore 
    Issue #2685139 by rromore, vgardner: Implement FBIA configuration on a...
vgardner’s picture

vgardner
Location London
commented
Status: Active » Fixed

Thanks for this change @rromore. There's been a few reports about the issue which this fix solves, so I'm applying the patch now. For my comments I've created two separate tickets.

Create separate FBIA fieldset for node edit form: https://www.drupal.org/node/2688239

Ability to exclude articles when all articles are included by default: https://www.drupal.org/node/2688241

vgardner’s picture

vgardner
Location London
commented
StatusFileSize
new configure_fbia_per_node-2685139_2.patch10.9 KB

This was the patch I applied.

steffenr’s picture

steffenr
Primary language German
commented

Great to read that you implemented an option to show specific nodes in the rss feed instead of all the nodes. As i was testing your module with our articles on daskochrezpt.de i ran into the issue, that there was too much content for the feed and PHP just quit with an memory_error (although i had 1024MB on my testing machine) .

I hope i'll find some time next week to talk to you about merging both the facebook_instant_articles 7.x-1.x branch with your efforts. All the field-formatter stuff already done in your module is really great. In combination with the views integration and row output as rendered view mode it would fit most of the cases i think.

SteffenR

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Fixed » Closed (fixed)

Running through and closing issues that are marked Fixed.