Closed (fixed)
Project:
Examples for Developers
Version:
8.x-1.x-dev
Component:
DBTNG Example
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Mar 2016 at 13:59 UTC
Updated:
31 Mar 2016 at 17:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
_vl_ commentedError in filename (case sensitive)
Comment #3
_vl_ commentedComment #4
_vl_ commentedComment #7
metzlerd commentedThe patch here looks like the whole file changed? Any chance that you're editor is changing line feeds on this one? It makes it difficult to see what's changed in the patch. I think that CI errors are problems with the test bot and not your patch,as the 8.x.1.x branch is passing all tests.
Comment #8
heykarthikwithuA similar change in code.
Comment #11
heykarthikwithuComment #12
metzlerd commentedI'll have to apply the patch to be sure, but now I'm beginning to understand what's going on here. We are trying to rename the file in case (OF COURSE, aren't I a dits) so the path files will probably need to rename the whole files. It may be the first patch was correct and the second is wrong. I'm so sorry for the confusioni I may have introduced here.
Comment #14
mile23No doubt this is a follow-up to #2668656: DBTNG Example has incorrect directory structure, acronym names
The test problems are related to a branch failure.
There is also a case disparity with
dbtng_example/src/Tests/DbtngExampleTest.php, fixed in commit.Passes locally using run-tests.sh
Thanks, folks!