Removal of depreciated methods and unused imports in code base.

CommentFileSizeAuthor
#8 interdiff-2685585-2-8.txt1.32 KBheykarthikwithu
#8 2685585-8.patch45.03 KBheykarthikwithu
#2 2685585-2.patch44.06 KBheykarthikwithu

Comments

heykarthikwithu created an issue. See original summary.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: heykarthikwithu » Unassigned
Status: Active » Needs review
StatusFileSize
new 2685585-2.patch44.06 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2685585-2.patch, failed testing.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 2685585-2.patch, failed testing.

The last submitted patch, 2: 2685585-2.patch, failed testing.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: Unassigned » heykarthikwithu
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: heykarthikwithu » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2685585-8.patch45.03 KB
new interdiff-2685585-2-8.txt1.32 KB

Status: Needs review » Needs work

The last submitted patch, 8: 2685585-8.patch, failed testing.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Status: Needs work » Needs review
mikeytown2’s picture

mikeytown2 commented

Looks like the patch keeps failing on PHP 7. I'd recommend installing that locally and seeing what is causing the fatal errors.

Status: Needs review » Needs work

The last submitted patch, 8: 2685585-8.patch, failed testing.

mikeytown2’s picture

mikeytown2 commented
Status: Needs work » Needs review

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented

Cherry picking this a bit - some things are done by other commits.
Firstly just applying the standards as fixed here to match the namespace standards: #1353118: [Obsolete] Namespaces (any/namespaced/class/with/a/slash should be 'used').

  • NickWilde committed 76c9b7c on 8.x-2.x 
    Issue #2685585 by heykarthikwithu, NickWilde: Depreciated methods and...
nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs review » Fixed

Not including fixes/changes to the /tests directory as it is not really ported yet but when I port those tests/make new ones I'll keep those in mind.
That last commit basically finishes the cherry picking.
Thanks again :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.