When trying to create a new user - there is a block and the following error is reported

The website encountered an unexpected error. Please try again later.

Exception: Cannot get user preference, uid missing in comment_notify_get_user_notification_setting() (line 21 of modules/comment_notify/comment_notify.inc).

Drupal 8.0.5
PHP 7.0.3
MySQL 5.5.47-0+deb7u1-log

Linux info 3.0 #1337 SMP Tue Jan 01 00:00:00 CEST 2000 all GNU/Linux

Comment Notify 8.x-1.x-dev (2015-Nov-16)

Workaround was to create new user with drush.

CommentFileSizeAuthor
#10 2684617-10.patch703 byteschegor
#7 comment_notify-2684617-user-form.patch861 bytesjohn.money

Comments

washburn created an issue. See original summary.

martinma’s picture

martinma commented

I just have the same problem too, so I cant use this very usefull modul. I think priority should be "major".

martinma’s picture

martinma commented
Priority: Normal » Major
Homeowner One’s picture

Homeowner One commented

Comment Notify is a great module and needed. It generally works as expected, but blocks 'Create New User' and 'Create Account' by anonymous users. What can I do to help? Thanks for the hard work on this project. Has there been any updates since 11/2015? When will this module be ready for Drupal 8 install?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Hi,

I agree this is a high priority bug. Unfortunately I don't have any Drupal 8 sites, so I'm really looking to the community to provide patches (and tests, ideally). Any chance you have ideas on what the right fix is?

washburn’s picture

washburn commented

I have bypassed the limitation of not creating a new user through Drupal interface by using drush

drush user-create newuser --mail="person@example.com" --password="letmein"
drush user-add-role "administrator" --name="newuser"

You can fix the values in the above commands or log in as newuser and then adjust the values.

john.money’s picture

john.money commented
Status: Active » Needs review
StatusFileSize
new comment_notify-2684617-user-form.patch861 bytes

Patch tested with both admin/people/create and user/register endpoints.

Status: Needs review » Needs work

The last submitted patch, 7: comment_notify-2684617-user-form.patch, failed testing.

The last submitted patch, 7: comment_notify-2684617-user-form.patch, failed testing.

chegor’s picture

chegor commented
StatusFileSize
new 2684617-10.patch703 bytes

Updated patch

chegor’s picture

chegor commented
Status: Needs work » Needs review
manumad40’s picture

manumad40 commented

Patch from #10 works for me.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Priority: Major » Critical
Status: Needs review » Reviewed & tested by the community

Looks ok to me, could also do a isNew() check instead of id(). I'd say this is critical.

  • greggles committed f579362 on 8.x-1.x authored by chegor 
    Issue #2684617 by chegor, john.money, Berdir: Comment Notify seems to...
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch, the reroll, and the review!

Now committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2770889: Comment Notify Next release - 8.x-1.0-beta5