Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.There are several open issues for 8.x, but not many bugs, mostly features. To track the first stable release on 8.x, let's use this issue to track which issues are important to fix and which are optional.
Next release targeted issues:
Done:
Done! Yay!
* #2618192: Increase basic test coverage
* #2877283: Integrity constraint violation on anonymous's user comment update
* #2723063: Removing @file doc block from src files
* #2684617: Comment Notify seems to block Create New User on Drupal 8
* #2684153: Invalid tokens
* #2853329: Comment Notify block Create New User on Drupal 8 when the preferences are disabled.
* #2850935: Error when the user has been created and edit his profile for first time
* #2879914: Notifications not sent when user chooses "Replies to my comment"
* #2879921: Notifications sent when user edits comment
* #2865943: Notice: Trying to get property of non-object in comment_notify_form_user_form_alter()
* #2618182: Support all entity types as commentable, not only nodes
Comments
Comment #2
gregglesComment #3
gregglesComment #4
giorgio79 CreditAttribution: giorgio79 commentedCan't we do this with Rules in D8? :)
Comment #5
gregglesYou tell me, giorgio79 ;)
Comment #6
gregglesOK, there were patches with tests created for those issues. I committed them and made a beta1 release at https://www.drupal.org/project/comment_notify/releases/8.x-1.0-beta1
Let's get to RC/release!
Comment #7
naveenvalechaThanks! Greg
Comment #8
gregglesAdding a few more issues. I'd love to get a review or any help testing all of these.
Comment #9
DamienMcKennaI cross-linked the issues using the "parent" field, just to make it easier.
Comment #10
gbyte CreditAttribution: gbyte as a volunteer and commentedAdded #2877283: Integrity constraint violation on anonymous's user comment update to the 'worthwhile' list as module breaks core functionality.
Comment #11
toamit CreditAttribution: toamit commentedAdded the following in worthwhile fixes, as they have patches and I tested them, they work!
* #2618182: Support all entity types as commentable, not only nodes
* #2879914: Notifications not sent when user chooses "Replies to my comment"
* #2879921: Notifications sent when user edits comment
Comment #12
gregglesI've committed a few patches. Would be great to get a few more reviews on the remaining patches. I'll probably make a new beta release soon to help get more testers.
Comment #13
gregglesComment #14
gregglesComment #15
gnugetWe are ready to create a new beta.
:-D
Comment #16
gregglesSeems like a great idea to me. Thanks for all your work!
Comment #17
gnugetYou are welcome!
I'm going to create the new beta this night.
Comment #18
gregglesFor anybody following the issue, here's a link: https://www.drupal.org/project/comment_notify/releases/8.x-1.0-beta4
Comment #19
naveenvalechaThanks Greg! and @gnuget
Comment #20
naveenvalechaUpdated IS
Comment #21
gnugetReady for another release.
:-)
Comment #22
gnugetI just released the beta 5, I'm going to keep an eye on this because on this one we included #2618182: Support all entity types as commentable, not only nodes which is a big change.
https://www.drupal.org/project/comment_notify/releases/8.x-1.0-beta5
Comment #23
naveenvalechacan we close this issue and use the new issue for next release.
Comment #24
gnugetSounds good, let's do that.
Thanks!
Comment #25
naveenvalechaSweet Thanks!