Ignore status changes for continuous jobs

I'm not sure what I did. I might have accepted a job item.

so create a continuous job, create content, accept the translation for the job item. If it is the only one (or all are accepted), the job might currently switch to finished.

1. +++ b/src/JobInterface.php
   @@ -65,6 +65,20 @@ interface JobInterface extends ContentEntityInterface, EntityOwnerInterface {
   +   * A continuous translation job.
   +   *
   +   * A default state for all continuous jobs.
   +   */
   +  const STATE_CONTINUOUS = 6;
   

   We should make sure that the open_jobs filter includes this state too.

2. +++ b/tmgmt.module
   @@ -253,6 +253,7 @@ function tmgmt_job_match_item($source_language, $target_language, $account = NUL
      return !\Drupal::entityQuery('tmgmt_job_item')
        ->condition('tjid', $tjid)
   +    ->condition('tjid.entity.job_type', JobInterface::TYPE_NORMAL)
   

   I'm not sure that this does what you think it does. Now it will simply never find unfinished jobs for continuous jobs, which means it will always try to finish them? Wouldn't you have to check this in \Drupal\tmgmt\Entity\JobItem::accepted?

   My idea was to actually enforce this state in Job::preSave(). If continuous, and status is not continuous_inactive, force it to continuous.

   Also, I think we want an update function for this, or filters might not work correctly on this.

1. +++ b/src/Entity/JobItem.php
   @@ -481,8 +481,9 @@ class JobItem extends ContentEntityBase implements JobItemInterface {
   +    $job = $this->getJob();
   +    if (tmgmt_job_check_finished($this->getJobId()) && $job && !$job->isContinuous()) {
   +      // Mark the job as finished in case it is a normal job.
   

   Try reversing the conditions, if ($job && !$job->isContinuous() && ...check_finished()).

   Then you avoid a query for continuous jobs.

2. +++ b/src/Plugin/views/filter/JobState.php
   @@ -40,6 +40,8 @@ class JobState extends ManyToOne {
          '2' => 'Rejected',
          '4' => 'Aborted',
          '5' => 'Finished',
   +      '6' => 'Continuous',
   +      '7' => 'Continuous inactive',
   

   looks like we forgot to make these labels translatable() in the previous issue?

   Lets not make inactive visible in the UI when it's not used anywhere yet. So just add continuous.

+++ b/tmgmt.install
@@ -97,6 +97,7 @@ function tmgmt_update_8007() {
-    $continuous_job->setState(Job::STATE_CONTINUOUS);
+    $continuous_job->state = Job::STATE_CONTINUOUS;
+    $continuous_job->save();

I actually liked setState() here because then it only saves if necessary.

Ok, committed.