Mostly clarifications and typos. But there's one important change:

$settings['memcache']['key_prefix'] => '';

Becomes

$settings['memcache']['key_prefix'] = '';

CommentFileSizeAuthor
#5 update_documentation-2680347-5.patch2.97 KBjcnventura
#5 interdiff.txt1.5 KBjcnventura
#2 update_documentation-2680347-2.patch3.24 KBgokulnk
update-doc.patch3.14 KBanavarre

Comments

anavarre created an issue. See original summary.

gokulnk’s picture

gokulnk commented
StatusFileSize
new update_documentation-2680347-2.patch3.24 KB

I was reading up a little about Memcache Binary protocol and I was able to locate a working link. I have updated the documentation with the same. But anyways once we have the wiki on memcached github account we should update it accordingly.

damiankloip’s picture

damiankloip commented 
  1. +++ b/README.txt
@@ -32,11 +32,14 @@ is important.
+      $settings['cache']['default']['render'] = 'cache.backend.memcache';

    This is wrong I think? This should be:

    $settings['cache']['bins']['render'] = 'cache.backend.memcache' 

  2. +++ b/README.txt
@@ -175,6 +178,8 @@ See http://drupal.org/node/273824
+Note: this module hasn't yet been ported to memcache 8.x-2.x

    Why are we adding this comment? Otherwise looks good to me.

damiankloip’s picture

damiankloip commented
Status: Needs review » Needs work
jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.5 KB
new update_documentation-2680347-5.patch2.97 KB

Updated as per #3.

  • damiankloip committed 908c0a2 on 8.x-2.x 
    Issue #2680347 by jcnventura, anavarre, gokulnk: Update documentation
damiankloip’s picture

damiankloip commented
Status: Needs review » Fixed

Looks good to me now, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.