Remove sms_user_get_number() and sms_user_send() functions. they are duplicated by phone number provider.

Comments

dpi created an issue. See original summary.

dpi’s picture

dpi
Location Perth, Australia
commented
Component: Core Framework » SMS User
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Active » Needs review
  • Removed sms_user_get_number() and sms_user_send()
  • Updated previous helper usages to use phone number provider.
  • Reimplemented how SMS Blast sent its messages.

Green, Review patch: https://github.com/dpi/smsframework/pull/6

dpi’s picture

dpi
Location Perth, Australia
commented

I'll end up making a helper in the future since the process of creating phone number field storage & field config, and phone number settings will become repetitive.

  • dpi committed 5fe5f55 on 8.x-1.x 
    Issue #2679459 by dpi: Removed sms_user_get_number() and sms_user_send...
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs review » Fixed

Committed and included feedback from https://github.com/dpi/smsframework/pull/6

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.