Some SMS User functions are being replaced.

Adding Removing
#2643692: SMS User Redesign #2679459: Remove sms_user_get_number() and sms_user_send()
#2677676: Automated Messages & Sleep
#2707697: Update sendtophone to use phone number provider

After these are completed, then we can:

CommentFileSizeAuthor
#49 sms-user-features-remove-deprecated-2677690-49.patch95.9 KBdpi
#45 sms-user-features-remove-deprecated-2677690-45.patch75.43 KBdpi
#36 sms-user-features-remove-deprecated-2677690-31.patch87.34 KBdpi
#31 sms-user-features-remove-deprecated-2677690-27.patch88.03 KBdpi
#27 sms-user-features-remove-deprecated-2677690-27.patch88.03 KBdpi
#23 sms-user-features-remove-deprecated-2677690-23.patch75.74 KBdpi
#19 sms-queue-incoming-2709475.patch3.5 KBdpi
#15 sms-user-features-remove-deprecated-2677690-15.patch88.34 KBdpi
#8 sms-user-features-remove-deprecated-2677690.patch87.92 KBdpi

Comments

dpi created an issue. See original summary.

dpi’s picture

dpi
Location Perth, Australia
commented
Related issues: +#2643692: SMS User Redesign
dpi’s picture

dpi
Location Perth, Australia
commented
Assigned: Unassigned » dpi

Working on this tomorrow

dpi’s picture

dpi
Location Perth, Australia
commented
Title: Remove deprecated SMS User functions » [meta] Remove deprecated SMS User functions
Issue summary: View changes
dpi’s picture

dpi
Location Perth, Australia
commented
Assigned: dpi » Unassigned

#2677676: Automated Messages & Sleep is a prerequisite.

dpi’s picture

dpi
Location Perth, Australia
commented
Related issues: +#2650656: Rename sms_user_delete()

This will resolve #2650656: Rename sms_user_delete()

dpi’s picture

dpi
Location Perth, Australia
commented

I'm going to continue this issue by gutting functions out of core and sms_user once #2677676: Automated Messages & Sleep is in.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Active » Needs review
StatusFileSize
new sms-user-features-remove-deprecated-2677690.patch87.92 KB

Seeing what testbot thinks. Will post a PR and some related issue shortly

Status: Needs review » Needs work

The last submitted patch, 8: sms-user-features-remove-deprecated-2677690.patch, failed testing.

The last submitted patch, 8: sms-user-features-remove-deprecated-2677690.patch, failed testing.

The last submitted patch, 8: sms-user-features-remove-deprecated-2677690.patch, failed testing.

dpi’s picture

dpi
Location Perth, Australia
commented
Issue summary: View changes
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs work » Postponed

Issue blocked on #2707697: Update sendtophone to use phone number provider

dpi’s picture

dpi
Location Perth, Australia
commented

Issue blocked on #2707723: Update register via SMS feature to use phone number provider

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Postponed » Needs review
StatusFileSize
new sms-user-features-remove-deprecated-2677690-15.patch88.34 KB

Updating for HEAD to help me develop #2707723: Update register via SMS feature to use phone number provider. No need to review.

Status: Needs review » Needs work

The last submitted patch, 15: sms-user-features-remove-deprecated-2677690-15.patch, failed testing.

The last submitted patch, 15: sms-user-features-remove-deprecated-2677690-15.patch, failed testing.

The last submitted patch, 15: sms-user-features-remove-deprecated-2677690-15.patch, failed testing.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs work » Needs review
StatusFileSize
new sms-queue-incoming-2709475.patch3.5 KB

Just running tests

Status: Needs review » Needs work

The last submitted patch, 19: sms-queue-incoming-2709475.patch, failed testing.

The last submitted patch, 19: sms-queue-incoming-2709475.patch, failed testing.

The last submitted patch, 19: sms-queue-incoming-2709475.patch, failed testing.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs work » Needs review
StatusFileSize
new sms-user-features-remove-deprecated-2677690-23.patch75.74 KB

Wrong file

Status: Needs review » Needs work

The last submitted patch, 23: sms-user-features-remove-deprecated-2677690-23.patch, failed testing.

The last submitted patch, 23: sms-user-features-remove-deprecated-2677690-23.patch, failed testing.

The last submitted patch, 23: sms-user-features-remove-deprecated-2677690-23.patch, failed testing.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs work » Needs review
StatusFileSize
new sms-user-features-remove-deprecated-2677690-27.patch88.03 KB

As of 023ce24

Status: Needs review » Needs work

The last submitted patch, 27: sms-user-features-remove-deprecated-2677690-27.patch, failed testing.

The last submitted patch, 27: sms-user-features-remove-deprecated-2677690-27.patch, failed testing.

The last submitted patch, 27: sms-user-features-remove-deprecated-2677690-27.patch, failed testing.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs work » Needs review
StatusFileSize
new sms-user-features-remove-deprecated-2677690-27.patch88.03 KB

Old test snuck back in

Status: Needs review » Needs work

The last submitted patch, 31: sms-user-features-remove-deprecated-2677690-27.patch, failed testing.

The last submitted patch, 31: sms-user-features-remove-deprecated-2677690-27.patch, failed testing.

The last submitted patch, 31: sms-user-features-remove-deprecated-2677690-27.patch, failed testing.

almaudoh’s picture

almaudoh commented

I'm still reviewing this patch

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs work » Needs review
StatusFileSize
new sms-user-features-remove-deprecated-2677690-31.patch87.34 KB

Yuck I just posted the wrong patch again.

PR is here: https://github.com/dpi/smsframework/pull/15/files

Should be easy review. Make a list of any features that need replacements (if any)

Edit: no problems, PR above for easy reading
Edit2: test failure is random, see #2712613: Account creation fails when the regex delimiter is included in the incoming message

Status: Needs review » Needs work

The last submitted patch, 36: sms-user-features-remove-deprecated-2677690-31.patch, failed testing.

almaudoh’s picture

almaudoh commented 
+++ b/modules/sms_user/config/install/sms_user.settings.yml
index ee4d82b..0000000
--- a/modules/sms_user/config/optional/views.view.sms_user_admin.yml

Are we losing this view completely? We should move it elsewhere...

Other key functionality I've not yet seen in other patches which are being removed here include: user registration form integration; user login form integration; rules integration; etc. Unfortunately, we didn't originally have test coverage for these.

Let me have some time to look at this patch in more detail.

dpi’s picture

dpi
Location Perth, Australia
commented

Are we losing this view completely? We should move it elsewhere...

Is this useful? A view to see the phone numbers of entities? Hmm

user registration form integration; user login form integration;

Since phone number is a regular field, admins can expose the phone number field for registration forms. (/admin/config/people/accounts/form-display)

rules integration;

We need Rules before we can have Rules integration ;) They are still in alpha / unstable API. I am also tracking this for RNG.

almaudoh’s picture

almaudoh commented

We need Rules before we can have Rules integration ;)

Then we should have an issue for that I guess :)

Since phone number is a regular field, admins can expose the phone number field for registration forms. (/admin/config/people/accounts/form-display)

Good point. Should we have that as part of this patch (or a new issue)? Or do we let site builders (who may not be aware that that feature exists) decide that for themselves?

dpi’s picture

dpi
Location Perth, Australia
commented

I go with let the site builders do it on their own. Its like 3 clicks for them.

We already make admins choose whether they want to create a phone number field on the (user) entity. So they should be able to make the conclusion that if its a regular field, they can expose it on the registration form.

At best, its a "how to" article on stack exchange or a Drupal tutorial/tips site.

dpi’s picture

dpi
Location Perth, Australia
commented
Related issues: +#2712599: [meta] Rules integration
We need Rules before we can have Rules integration ;)

Then we should have an issue for that I guess :)

Done! #2712599: [meta] Rules integration

almaudoh’s picture

almaudoh commented

Thanks!!

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs work » Active

Let me have some time to look at this patch in more detail.

Where do we stand with this one? I want to be sure, since this PR removes 2500 lines.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Active » Needs review
StatusFileSize
new sms-user-features-remove-deprecated-2677690-45.patch75.43 KB

Status: Needs review » Needs work

The last submitted patch, 45: sms-user-features-remove-deprecated-2677690-45.patch, failed testing.

The last submitted patch, 45: sms-user-features-remove-deprecated-2677690-45.patch, failed testing.

The last submitted patch, 45: sms-user-features-remove-deprecated-2677690-45.patch, failed testing.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs work » Needs review
StatusFileSize
new sms-user-features-remove-deprecated-2677690-49.patch95.9 KB

oops, reintroduced old test from merge.

  • dpi committed 81d7e61 on 8.x-1.x 
    Issue #2677690 by dpi: Removed deprecated SMS User functions

Over the...
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs review » Fixed

The last submitted patch, 8: sms-user-features-remove-deprecated-2677690.patch, failed testing.

The last submitted patch, 15: sms-user-features-remove-deprecated-2677690-15.patch, failed testing.

The last submitted patch, 19: sms-queue-incoming-2709475.patch, failed testing.

The last submitted patch, 23: sms-user-features-remove-deprecated-2677690-23.patch, failed testing.

The last submitted patch, 27: sms-user-features-remove-deprecated-2677690-27.patch, failed testing.

The last submitted patch, 31: sms-user-features-remove-deprecated-2677690-27.patch, failed testing.

The last submitted patch, 36: sms-user-features-remove-deprecated-2677690-31.patch, failed testing.

The last submitted patch, 45: sms-user-features-remove-deprecated-2677690-45.patch, failed testing.

Status: Fixed » Needs work

The last submitted patch, 49: sms-user-features-remove-deprecated-2677690-49.patch, failed testing.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.