As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.
Here is the summary of running ESLint on this module JS:
XXX problems.

Attached is the full list of errors found by ESLint and the patch that fixes them.

CommentFileSizeAuthor
#7 eslinterrors-2679335-7.patch4 KBPurnachandra Rao V
simple_social_icons.patch3.26 KBPurnachandra Rao V

Comments

Purnachandra Rao V created an issue. See original summary.

krknth’s picture

krknth commented
Assigned: Purnachandra Rao V » krknth

@Purnachandra Rao V : Thanks, checking your patch.

Purnachandra Rao V’s picture

Purnachandra Rao V commented
Status: Active » Needs review
Purnachandra Rao V’s picture

Purnachandra Rao V commented

Please check this patch and confirm.

krknth’s picture

krknth commented
Status: Needs review » Reviewed & tested by the community
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: krknth » Unassigned
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

patch does not apply to latest code, needs a re roll.

Purnachandra Rao V’s picture

Purnachandra Rao V commented
StatusFileSize
new eslinterrors-2679335-7.patch4 KB

Latest file some one added code.
Please find updated patch.

Purnachandra Rao V’s picture

Purnachandra Rao V commented
Status: Needs work » Needs review
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Version: 8.x-1.0-alpha1 » 8.x-1.x-dev
Assigned: Unassigned » heykarthikwithu
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

Looks fine.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: heykarthikwithu » Unassigned
Status: Reviewed & tested by the community » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.