In the BigPipe D8.1 core issue, @effulgentsia said this at #2469431-258: BigPipe for auth users: first send+render the cheap parts of the page, then the expensive parts.10:
So here we have a strategy that outputs the placeholder to the client. As opposed to previously in HEAD, where placeholder markup was assumed to only live on the server, such as within render cache entries. It seems not ideal to me for someone on a production site, with no special permissions, to be able to "view source" and see the PHP callback and arguments of the lazy builder, or potentially similar server-side-specific information that might be in $original_placeholder.
TBD
TBD
None.
TBD
TBD
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 2678658-7.patch | 9.94 KB | wim leers |
Comments
Comment #2
wim leersComment #4
wim leersComment #5
wim leersTriaged by @Fabianx and I at DrupalCon New Orleans.
We +1'd.
Pseudocode attached.
Comment #7
wim leersHere's a step forward. This injects the
renderer.configinstead of talking to the container. That required making some class methods instance methods.This also adds a
debugkey to therenderer.configcontainer parameter. We'll also need that in #2667190: Create a single "debug output" setting and #2381797: Add render_cache debug output.This still won't pass all tests, but will at least pass the unit test.
Comment #9
wim leersThis is blocked on review from @effulgentsia.
Comment #10
wim leersIMO this is minor at most. Could easily happen in 8.2 or 8.3. Not necessary to make BigPipe stable.
Comment #11
wim leersComment #14
wim leersThis went two cycles (see comments #12 + #13) without a single comment. It's really been blocked on feedback since May 2016, which is almost 9 months ago.
If in 9 months nobody felt like reviewing this or even saying "yes please do this", I think it's fair to say this is not actually important. And to be perfectly clear: there's no way that metadata can be modified to retrieve different information.