Coding Standard fixes

Working on this.

Patch for Code cleaup as per pareview.sh

Thanks! this will not fix all the issues as per pareview but as per latest coding standard changes. remove the @file from classes,intefaces and traits file.

updating patch as per coding standards referred from https://www.drupal.org/coding-standards/docs#file .

Re-rolling the patch.

we don't need tests here. Removing the tag that was added in #4

needs a reroll after #2770037: Removed @file tag .

1. +++ b/coffee.coffee.inc
   @@ -2,8 +2,7 @@
   + * The hooks that are used by Coffee includes an example of hook_coffee_commands().
   

   Line is 82 chars

2. +++ b/js/coffee.js
   @@ -32,13 +32,8 @@
   -  /**
   -   * Coffee module namespace
   -   *
   -   * @namespace
   -   *
   -   * @todo put this in Drupal.coffee to expose it.
   -   */
   
   @@ -51,7 +46,7 @@
   +   * @todo get most of it out of the behavior in dedicated functions.
   
   @@ -212,11 +206,7 @@
   -  /**
   -   * The HTML elements.
   -   *
   -   * @todo use Drupal.theme.
   -   */
   

   Please revert these changes. The coding standards are properly applied here

3. +++ b/src/Controller/CoffeeController.php
   @@ -188,9 +183,9 @@ class CoffeeController extends ControllerBase {
   +      // @var $instances \Drupal\Core\Menu\LocalTaskInterface[].
   

   Please revert this change. /** @var ...**/ is used by phpstorm for retrieve type information for the variable

Attaching the re-rolled patch here..

@neerajsingh,
Please provide the interdiff it would be easier to review the changes https://www.drupal.org/documentation/git/interdiff

@naveenvalecha, Patch at #10 doesn't apply any more after #2770037: Removed @file tag .

Hence patch at #14 is a new patch. Do we still need a interdiff ?

Alright then this needs test on pareview.sh as my setup of pareview.sh on my local is pretty old.

Steps to test :

Apply the path to a sperate branch
Run that branch against coding standards requirement on pareview.sh and post the link here.

Neeraj,
Now this is in admin's radar, let's get the review from them after this patch gets committed.
Thanks!

ok, so i grabbed branch 8.x-1.x from coffee repo,
applied patch #3
then applied locally latest pareview.sh from its github repo
and these are the results:

FILE: /home/leandro/git/coffee/coffee.coffee.inc
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 6 | ERROR | Doc comment short description must be on a single line,
   |       | further text should be a separate paragraph
--------------------------------------------------------------------------


FILE: ...me/leandro/git/coffee/tests/modules/coffee_test/coffee_test.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | WARNING | Remove "version" form the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------


FILE: /home/leandro/git/coffee/coffee.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 83 | WARNING | Translatable strings must not begin or end with white
    |         | spaces, use placeholders with t() for variables
--------------------------------------------------------------------------


FILE: /home/leandro/git/coffee/src/Tests/CoffeeTest.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 77 | WARNING | [x] A comma should follow the last multiline array item.
    |         |     Found: 'account'
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: /home/leandro/git/coffee/src/Controller/CoffeeController.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 187 | ERROR | Inline doc block comments are not allowed; use "/* Comment
     |       | */" or "// Comment" instead
--------------------------------------------------------------------------


FILE: /home/leandro/git/coffee/css/coffee.css
--------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
 173 | ERROR | [x] Spaces must be used to indent lines; tabs are not
     |       |     allowed
 173 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 174 | ERROR | [x] Spaces must be used to indent lines; tabs are not
     |       |     allowed
 174 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 175 | ERROR | [x] Spaces must be used to indent lines; tabs are not
     |       |     allowed
 175 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
 176 | ERROR | [x] Spaces must be used to indent lines; tabs are not
     |       |     allowed
 176 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 273ms; Memory: 9.25Mb

Updated patch as said in #18.

besides phpcs warns a lot of errors
my local pareview.sh seems to be happy with latest patch
and gives no errors ...

Fixed the phpcs issues I found. Please review.

ok latest patch is ok for both pareview and phpcs
good work!

Committed and pushed to 8.x. Thanks!