Page cache for anonymous users is not cleared when using Views

Views based on a search api index should not be cacheable, see http://cgit.drupalcode.org/search_api/tree/src/UncacheableDependencyTrai... so if those are cached, this is a bug and the http://cgit.drupalcode.org/search_api/tree/src/Tests/CacheabilityTest.ph... is not specific enough.

Just tried it out myself, but it seems to work as expected. Are you sure you're using the latest version of the module?

Here's a test that proves the issue. The problem is that there is no node_list or similar tag added to search api views blocks so the whole page is still cached after adding a new item to the index.

Setting to Needs review to show the failing test.

Changed the tests up a bit so here's another failing test patch plus the fix. Happy to change the placement of both the test and the fix if required.

Fixed failure.

I think this looks good, let's get this in.

Thanks for providing a test, and a patch to fix the problem.
However, this should then also be done when deleting items, right?

Furthermore: Wouldn't it be more sensible to have index-specific tags? Clearing views on index A when indexing on index B doesn't seem useful, and it seems this would be very easy to implement.
And, if we have that: doesn't that make the existing entity-type list tags useless and actually detrimental?
Finally, not included in my revision: Why is the new test in the (functional) CacheabilityTest class instead of the (Kernel) ViewsDisplayCachingTest?

That being said, though, this is definitely already a big improvement. However, it should also be clear that tag-based caching for search queries currently just doesn't work reliably. You can use it, if you want, but you shouldn't expect it to work in all scenarios.

Patch attached, please test/review!

Nice improvements, thanks @drunken monkey. Reason the test was there is simply because I failed to find ViewsDisplayCachingTest before posting the patch, sorry about that!

1. +++ b/tests/src/Functional/CacheabilityTest.php
   @@ -57,4 +57,30 @@ public function testFramework() {
   +    // Get the page again.
   +    $this->drupalGet('search-api-test-search-view-caching-tag');
   +    $this->assertSession()->pageTextContains('Displaying 6 search results');
   

   Can we improve this comment?

   // Check that the newly indexed node is visible on the search index.

2. +++ b/tests/src/Functional/CacheabilityTest.php
   @@ -57,4 +57,30 @@ public function testFramework() {
   +    // Get the page again.
   

   Check that the deleted entity is now no longer hidden.

Fixed #18

Looks great

Excellent, thanks for the review and thanks for the improved patch!
Committed.
Thanks again, everyone!