[D7] Yesmail Integration

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxejh32664650git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

The vast majority is style issues that can be cleaned up to pass auto inspection. Didn't see any issues of substance.

Hello jh3,

My findings for your module as follows:

I think it would be nice to use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
Please check line 309: yesmail_email.module

$transactional = $email->settings['transactional'] ? true : false;

To

$transactional = $email->settings['transactional'] ? TRUE : FALSE;

Thank you,

Hello jh3,

Module Looks good and working fine for me , some findings for your module as follows:

1: Follow the Readme template for the readme.txt https://www.drupal.org/node/2181737
2: Please use indent of 4 spaces for composer.json
3: Please add hook_help
4: Remove "Delete button" from Add yesmail email form (http://www.drupal-7./admin/config/services/yesmail/email/add)

@visabhishek: Looks like you forgot to change the status. Is this now RTBC after your review or are there application blockers left and this should be "needs work"?

Hi klausi ,

I think we dont have any blocker points. So i am marking as RTBC.

@jh3 : Its really good, if you consider my points before full project release.

There is just enough room in the Title field to enter <script>alert('hack!');</script>, and then I get an alert when I load the page. Arguably, this is not a security problem because the character limit is too small to do anything worse.

I see that you have applied filter_xss_admin() to the description, but it seems that you have not done anything to sanitize the title.

Note that entering something like My <title> will break the page layout.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

1. Please update the project page with valid URL's.
2. modules/yesmail_email/yesmail_email.module#n214 user_access will return TRUE or FALSE.
3. src/Connection/YesmailConnectionFactory.php#n51 drupal_set_message is visible to any user, use watchdog() for error reporting to administrators and a user friendly message for visitors.
4. If you're trying to validate an e-mail address, the implementation is way to complex, Drupal and PHP have their own validators already.
5. Anyhow, please update to jquery validation 1.16 and try to use more 'early returns' in your code.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.