This is a #2512702: Implement configuration UI follow-up. Configuration UI was added to the module, but it is responsibility of individual plugins to provide forms for their part of configuration.

See \Drupal\entity_browser\Plugin\EntityBrowser\Display\IFrame for example implementation.

Comments

slashrsm created an issue. See original summary.

boobaa’s picture

boobaa
he/him
commented
Assigned: Unassigned » boobaa

I'm working on this.

boobaa’s picture

boobaa
he/him
commented
Assigned: boobaa » Unassigned
Status: Active » Needs review

Pull Request is sent on GitHub.

slashrsm’s picture

slashrsm commented
Status: Needs review » Needs work

Few comments on pull.

boobaa’s picture

boobaa
he/him
commented

Replied to comments on the PR.

slashrsm’s picture

slashrsm commented

Responded.

boobaa’s picture

boobaa
he/him
commented
Status: Needs work » Needs review

Updated PR following the advices in comments on it. I think (and hope) it can be committed now. :)

slashrsm’s picture

slashrsm commented
Status: Needs review » Fixed

Rebased, squashed and merged. Thanks. Should we open that follow-up about missing views module?

boobaa’s picture

boobaa
he/him
commented

AFAIK Views module is no longer missing, thanks to dawehner's advice.

  • slashrsm committed 620b4eb on 8.x-1.x authored by Boobaa 
    Issue #2671810 by Boobaa: Implement configuration form for View widget

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.