Followup from #1061438: "On" and "Off" values for boolean fields are not translatable.

\Drupal\Core\Field\Plugin\Field\FieldFormatter\BooleanFormatter is missing settingsSummary().

CommentFileSizeAuthor
#5 interdiff-2671446-2-5.txt767 bytesheykarthikwithu
#5 2671446-5.patch2.14 KBheykarthikwithu
#2 2671446-2-boolean-settingsSummary.patch1.24 KBmikeker

Comments

mikeker created an issue. See original summary.

mikeker’s picture

mikeker commented
Status: Active » Needs review
StatusFileSize
new 2671446-2-boolean-settingsSummary.patch1.24 KB
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

A test would be amazing :)

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: Unassigned » heykarthikwithu

working on this

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: heykarthikwithu » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2671446-5.patch2.14 KB
new interdiff-2671446-2-5.txt767 bytes

Added the test case.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs tests

Looks good to me.

  • catch committed 89eadd7 on 8.1.x 
    Issue #2671446 by heykarthikwithu, mikeker: The Boolean field formatter...
catch’s picture

catch
he/him
Primary language English
commented
Version: 8.0.x-dev » 8.1.x-dev
Status: Reviewed & tested by the community » Fixed

This adds a new string so leaving it out of 8.0.x ,but committed/pushed to 8.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.