Hi there. I noticed that I couldn't access any of the importer pages (I was getting an access denied as an administrator), so I took a look at the code and discovered the page permission strings were defined with a trailing period, not matching the actual permissions defined by Metatag itself.

CommentFileSizeAuthor
#8 metatag-n2670842-8.patch1.59 KBDamienMcKenna
#5 metatag-metatag_importer_permissions-2670842.patch1.62 KBAmbient.Impact
#2 metatag-metatag_importer_permissions-2670842.patch1.62 KBAmbient.Impact
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Ambient.Impact created an issue. See original summary.

Ambient.Impact’s picture

Ambient.Impact
they/them
Primary language English
Location Toronto
CreditAttribution: Ambient.Impact as a volunteer commented
Assigned: Unassigned » Ambient.Impact
Status: Active » Needs review
FileSize
metatag-metatag_importer_permissions-2670842.patch1.62 KB

Status: Needs review » Needs work

The last submitted patch, 2: metatag-metatag_importer_permissions-2670842.patch, failed testing.

The last submitted patch, 2: metatag-metatag_importer_permissions-2670842.patch, failed testing.

Ambient.Impact’s picture

Ambient.Impact
they/them
Primary language English
Location Toronto
CreditAttribution: Ambient.Impact as a volunteer commented
Status: Needs work » Needs review
FileSize
metatag-metatag_importer_permissions-2670842.patch1.62 KB

Oops. Let's see if this one passes. I think I pasted an extra newline copying it from TortoiseGit.

Status: Needs review » Needs work

The last submitted patch, 5: metatag-metatag_importer_permissions-2670842.patch, failed testing.

The last submitted patch, 5: metatag-metatag_importer_permissions-2670842.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
metatag-n2670842-8.patch1.59 KB

Oh dear! I wonder what on earth I was doing to leave such a daft bug in place, must have been some search/replace silliness somewhere. I'm sorry about that.

This patch should apply ok.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #2663006: Plan for Metatag 7.x-1.14 release
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Title: Metatag Importer access denied » Metatag Importer permissions typo

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Assigned: Ambient.Impact » Unassigned
Status: Needs review » Fixed

Committed. Thanks!

Ambient.Impact’s picture

Ambient.Impact
they/them
Primary language English
Location Toronto
CreditAttribution: Ambient.Impact as a volunteer commented

Thanks, and sorry about the patch. :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.