Hi there. I noticed that I couldn't access any of the importer pages (I was getting an access denied as an administrator), so I took a look at the code and discovered the page permission strings were defined with a trailing period, not matching the actual permissions defined by Metatag itself.

CommentFileSizeAuthor
#8 metatag-n2670842-8.patch1.59 KBdamienmckenna
#5 metatag-metatag_importer_permissions-2670842.patch1.62 KBambient.impact
#2 metatag-metatag_importer_permissions-2670842.patch1.62 KBambient.impact

Comments

Ambient.Impact created an issue. See original summary.

ambient.impact’s picture

ambient.impact
they/them
Primary language English
Location Toronto
commented
Assigned: Unassigned » ambient.impact
Status: Active » Needs review
StatusFileSize
new metatag-metatag_importer_permissions-2670842.patch1.62 KB

Status: Needs review » Needs work

The last submitted patch, 2: metatag-metatag_importer_permissions-2670842.patch, failed testing.

The last submitted patch, 2: metatag-metatag_importer_permissions-2670842.patch, failed testing.

ambient.impact’s picture

ambient.impact
they/them
Primary language English
Location Toronto
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-metatag_importer_permissions-2670842.patch1.62 KB

Oops. Let's see if this one passes. I think I pasted an extra newline copying it from TortoiseGit.

Status: Needs review » Needs work

The last submitted patch, 5: metatag-metatag_importer_permissions-2670842.patch, failed testing.

The last submitted patch, 5: metatag-metatag_importer_permissions-2670842.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n2670842-8.patch1.59 KB

Oh dear! I wonder what on earth I was doing to leave such a daft bug in place, must have been some search/replace silliness somewhere. I'm sorry about that.

This patch should apply ok.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2663006: Plan for Metatag 7.x-1.14 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Metatag Importer access denied » Metatag Importer permissions typo

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: ambient.impact » Unassigned
Status: Needs review » Fixed

Committed. Thanks!

ambient.impact’s picture

ambient.impact
they/them
Primary language English
Location Toronto
commented

Thanks, and sorry about the patch. :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.