Remove EditorEntity aliasing in core/modules/ckeditor/src/Plugin/Editor/CKEditor.php

use Drupal\editor\Entity\Editor as EditorEntity;

CommentFileSizeAuthor
#8 interdiff-2668828-2-8.txt2.86 KBheykarthikwithu
#8 2668828-8.patch5.49 KBheykarthikwithu
#2 2668828-2.patch2.33 KBheykarthikwithu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heykarthikwithu created an issue. See original summary.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Assigned: heykarthikwithu » Unassigned
Status: Active » Needs review
FileSize
2668828-2.patch2.33 KB
naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia commented
Status: Needs review » Reviewed & tested by the community

This makes sense to in. RTBC if green
Thanks!

#2641528: Replace deprecated usage of entity_create('editor') with a direct call to Editor::create() would needs reroll when this issue went in.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Category: Bug report » Task
Priority: Normal » Minor
Issue tags: +Quickfix

Hah!

Note that #1992744: Add a dedicated @Editor plugin annotation introduced this, because we used to also have this:

use Drupal\editor\Annotation\Editor;

But for a long time, the need to import those classes has not been necessary anymore. So we can indeed also remove this.

It feels nice to be able to remove this oddity. Thank you, much appreciated!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Reviewed & tested by the community » Needs work

Please also include the changes in #2668838: Remove EditorEntity aliasing in Drupal\editor_test\Plugin\Editor\TRexEditor.php and #2668840: Remove EditorEntity aliasing in Drupal\editor_test\Plugin\Editor\UnicornEditor.php.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Assigned: Unassigned » heykarthikwithu

working on this.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

Thanks!

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Assigned: heykarthikwithu » Unassigned
Status: Needs work » Needs review
FileSize
2668828-8.patch5.49 KB
interdiff-2668828-2-8.txt2.86 KB
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community

Thanks!

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia commented

Yay!
RTBC +1
This needs a better title now

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Title: Remove EditorEntity aliasing in core/modules/ckeditor/src/Plugin/Editor/CKEditor.php » Remove EditorEntity aliasing in core/modules/*
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Title: Remove EditorEntity aliasing in core/modules/* » Remove EditorEntity aliasing in editor & ckeditor modules
naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia commented
Title: Remove EditorEntity aliasing in editor & ckeditor modules » Remove EditorEntity aliasing in editor & ckeditor module

  • catch committed a67f54c on 8.1.x 
    Issue #2668828 by heykarthikwithu, naveenvalecha: Remove EditorEntity...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.