Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quicksketch’s picture

Status: Active » Needs review
FileSize
8.98 KB

Straightforward application of the pattern from #1986988-9: Add a dedicated @CKEditorPlugin annotation.

The only caveat was the necessity of aliasing on of the uses of "Editor" as a class name, since now both the annotation class Editor and the entity class Editor are competing for the same name. Aliasing the entity version made more sense to me and I figured it'd result in less magic than trying to alias an annotation plugin (if that's even possible), which would result in a renamed @EditorAnnotation or something like that.

-use Drupal\editor\Plugin\Core\Entity\Editor;
+use Drupal\editor\Plugin\Core\Entity\Editor as EditorEntity;

Status: Needs review » Needs work

The last submitted patch, editor_annotations-1992744.patch, failed testing.

quicksketch’s picture

Status: Needs work » Needs review

#1: editor_annotations-1992744.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, editor_annotations-1992744.patch, failed testing.

quicksketch’s picture

Status: Needs work » Needs review
FileSize
8.98 KB

Hm, fighting with testbot Git today.

Status: Needs review » Needs work

The last submitted patch, editor_annotations-1992744.patch, failed testing.

quicksketch’s picture

Status: Needs work » Needs review
FileSize
8.98 KB

Ah, damn. It's capitalization that's the problem. I should have seen that coming.

aspilicious’s picture

Looking good....

quicksketch’s picture

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Yes sir

Wim Leers’s picture

RTBC +1

alexpott’s picture

Title: Add a dedicated @Editor plugin annotation » Change notice: Add a dedicated @Editor plugin annotation
Priority: Normal » Critical
Status: Reviewed & tested by the community » Active

Committed 96b2354 and pushed to 8.x. Thanks!

We need to ensure that any change notices are updated if they refer to editor plugins.

Wim Leers’s picture

Status: Active » Fixed

I updated http://drupal.org/node/1911614 to refer to the @Editor plugin annotation and to this issue.

Thanks! :)

alexpott’s picture

Title: Change notice: Add a dedicated @Editor plugin annotation » Add a dedicated @Editor plugin annotation
Priority: Critical » Normal

Updating title and priority

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.